After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629619 - introspection does not build with g-i 0.9.5
introspection does not build with g-i 0.9.5
Product: gnome-games-superseded
Classification: Deprecated
Component: general
Other Linux
: Normal normal
: ---
Assigned To: gnome-games-general-maint
GNOME Games maintainers
Depends on:
Reported: 2010-09-14 07:33 UTC by Götz Waschk
Modified: 2010-09-15 23:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Potential fix (595 bytes, patch)
2010-09-15 15:12 UTC, Vincent Untz
committed Details | Review

Description Götz Waschk 2010-09-14 07:33:27 UTC
This is with gnome-games 2.31.92 and gobject-introspection 0.9.5:

make[3]: Entering directory `/tmp/mdvsys_pvmZ/BUILD/gnome-games-2.31.92/libgames-support'
  GEN    GnomeGamesSupport-1.0.gir
ERROR: Option --strip-prefix has been replaced;
see --identifier-prefix and --symbol-prefix.
make[3]: *** [GnomeGamesSupport-1.0.gir] Fehler 1
Comment 1 Götz Waschk 2010-09-14 14:34:12 UTC
I have patched g-i to allow the option again, now I get this:

  GEN    GnomeGamesSupport-1.0.gir
g-ir-scanner: warning: Option --strip-prefix has been deprecated;
see --identifier-prefix and --symbol-prefix.
g-ir-scanner: compile: gcc -Wall -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gobject-introspection-1.0 -I/usr/lib/libffi-3.0.9/include -I.. -I.. -I/usr/include/json-glib-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/clutter-1.0 -I/usr/include/cairo -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libdrm -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gio-unix-2.0/ -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -c -o /home/goetz/svn/gnome-games/BUILD/gnome-games-2.31.92/libgames-support/tmp-introspectyz1CrN/GnomeGamesSupport-1.0.o /home/goetz/svn/gnome-games/BUILD/gnome-games-2.31.92/libgames-support/tmp-introspectyz1CrN/GnomeGamesSupport-1.0.c
g-ir-scanner: link: /bin/sh ../libtool --mode=link --tag=CC --silent gcc -o /home/goetz/svn/gnome-games/BUILD/gnome-games-2.31.92/libgames-support/tmp-introspectyz1CrN/GnomeGamesSupport-1.0 -L. -Wl,--export-dynamic -pthread -lgirepository-1.0 -lgobject-2.0 -lgmodule-2.0 -lffi -lgthread-2.0 -lrt -lglib-2.0 -lgames-support-gi -pthread -Wl,--export-dynamic -lgio-2.0 -lgirepository-1.0 -lgobject-2.0 -lgmodule-2.0 -lffi -lgthread-2.0 -lrt -lglib-2.0 /home/goetz/svn/gnome-games/BUILD/gnome-games-2.31.92/libgames-support/tmp-introspectyz1CrN/GnomeGamesSupport-1.0.o
Skipping foreign identifier 'GamesConf' from namespace GObject
make[3]: *** [GnomeGamesSupport-1.0.gir] Fehler 1
Comment 2 Vincent Untz 2010-09-15 15:12:18 UTC
Created attachment 170347 [details] [review]
Potential fix

This simple patch fixes the build for me. It feels correct to me, and the generated gir file has many things inside, so it could even be the right fix :-)
Comment 3 Colin Walters 2010-09-15 15:19:29 UTC
Review of attachment 170347 [details] [review]:

Looks right to me.
Comment 4 Colin Walters 2010-09-15 15:19:29 UTC
Review of attachment 170347 [details] [review]:

Looks right to me.
Comment 5 Christian Persch 2010-09-15 16:48:19 UTC
Please commit to master and gnome-2-32.
Comment 6 Vincent Untz 2010-09-15 18:55:37 UTC
Committed. Would it be possible to get a new tarball with this fix? I can handle it if needed.
Comment 7 Thomas Andersen 2010-09-15 22:31:13 UTC
I could do a new release sometime tomorrow. If you need it before then feel free to do it.
Comment 8 Vincent Untz 2010-09-15 23:09:08 UTC
Tomorrow is perfect -- I'm still waiting for the new glib.
Comment 9 Jason Clinton 2010-09-15 23:44:29 UTC
Thanks chpe and phomes!