After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629523 - Call Pixbuf.Savev directly instead of implementing the binding again
Call Pixbuf.Savev directly instead of implementing the binding again
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: 0.8.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-13 14:19 UTC by Mike Gemünde
Modified: 2010-09-13 21:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Call Pixbuf.Savev directly instead of implementing the binding again (3.15 KB, patch)
2010-09-13 14:19 UTC, Mike Gemünde 		reviewed Details | Review
Call Pixbuf.Savev directly instead of implementing the binding again (3.15 KB, patch)
2010-09-13 18:15 UTC, Mike Gemünde 		committed Details | Review

Description Mike Gemünde 2010-09-13 14:19:49 UTC 
Remove the hack and do not add the binding by our own.
Comment 1 Mike Gemünde 2010-09-13 14:19:51 UTC 
Created attachment 170152 [details] [review]
Call Pixbuf.Savev directly instead of implementing the binding again

The methods Pixbuf.Savev allows to specify arbitrary parameters to
gdk_pixbuf_save. So, there is no need to adding the binding
to the C function again.
Comment 2 Ruben Vermeersch 2010-09-13 14:24:31 UTC 
Review of attachment 170152 [details] [review]:

Was unaware that this was there. Feel free to push if it works (will test as well, but I'm confident that it'll work).
Comment 3 Ruben Vermeersch 2010-09-13 15:29:28 UTC 
Seems to be something wrong, I'm getting a lot of these:

(f-spot:7265): GdkPixbuf-WARNING **: Unrecognized parameter (t3\x89	) passed to PNG saver.
Comment 4 Mike Gemünde 2010-09-13 15:56:15 UTC 
Yeah, I also found it, but I fixed it. Seems that Savev does not add the terminating null to the argument list.
Comment 5 Mike Gemünde 2010-09-13 18:15:12 UTC 
Created attachment 170180 [details] [review]
Call Pixbuf.Savev directly instead of implementing the binding again

The methods Pixbuf.Savev allows to specify arbitrary parameters to
gdk_pixbuf_save. So, there is no need to adding the binding
to the C function again.

Next try....Seems like the terminating null is not added by the wrapper.
Comment 6 Ruben Vermeersch 2010-09-13 21:04:49 UTC 
Attachment 170180 [details] pushed as 706b6e1 - Call Pixbuf.Savev directly instead of implementing the binding again

Great, thanks!