After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629380 - Double contacts after adding new contact in group "Ungrouped"
Double contacts after adding new contact in group "Ungrouped"
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Meta Contacts
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-11 20:22 UTC by Pavol Klačanský
Modified: 2010-09-16 09:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add individuals to the EmpathyIndividualStore before updating them (1.50 KB, patch)
2010-09-15 15:27 UTC, Philip Withnall
accepted-commit_after_freeze Details | Review

Description Pavol Klačanský 2010-09-11 20:22:58 UTC
Steps to reproduce:
Add new contact
See at group "Ungrouped"

You need enable offline contacts displaying
Comment 1 Omer Akram 2010-09-12 13:17:46 UTC
Created attachment 170081 [details]
image
Comment 2 Omer Akram 2010-09-12 13:18:41 UTC
I am guessing its something related to the metacontacts maybe.
originally reported at: https://bugs.launchpad.net/bugs/634892
Comment 3 Pavol Klačanský 2010-09-12 14:20:51 UTC
Sorry, I don't have time for investigation :/, I am working on liferea patches now
Comment 4 Guillaume Desmottes 2010-09-13 08:46:57 UTC
Which version of Empathy and folks are you using?
Comment 5 Pavol Klačanský 2010-09-13 13:05:36 UTC
Emapthy: 2.31.91.1-0ubuntu3
Comment 6 Philip Withnall 2010-09-13 13:23:02 UTC
…and which version of folks?
Comment 7 Pavol Klačanský 2010-09-13 14:52:13 UTC
I cannot find package named folks :/
Comment 8 Philip Withnall 2010-09-13 15:13:56 UTC
You must have it; Empathy requires it. Look at the list of dependencies of the "empathy" package.
Comment 9 Pavol Klačanský 2010-09-13 15:33:25 UTC
sorry, I am silly
folks: 0.1.16-1
Comment 10 Philip Withnall 2010-09-13 17:13:50 UTC
Could you please get a log of the problem by running Empathy using the following command and either attaching the resulting log file here, or e-mailing it to me (philip.withnall@collabora.co.uk):

FOLKS_DEBUG=all EMPATHY_DEBUG=Contact,Tp empathy &> empathy.log
Comment 11 Pavol Klačanský 2010-09-14 16:12:16 UTC
Hallo, problem occurs only when I change nickname in adding dialog
Comment 12 Pavol Klačanský 2010-09-14 16:13:23 UTC
Created attachment 170259 [details]
log file
Comment 13 Philip Withnall 2010-09-15 15:27:46 UTC
Created attachment 170349 [details] [review]
Add individuals to the EmpathyIndividualStore before updating them

http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/629380-duplicate-contacts
Comment 14 Guillaume Desmottes 2010-09-16 08:33:24 UTC
Review of attachment 170349 [details] [review]:

++
We'll need a hard code freeze exception to merge this. Can you request one please?
Comment 15 Philip Withnall 2010-09-16 09:06:22 UTC
Requested.

Marking the bug as private due to the IM addresses in the attachment.
Comment 16 André Klapper 2010-09-16 09:18:48 UTC
(Please don't set group flags when not needed. Thanks.
Comment 17 André Klapper 2010-09-16 09:24:08 UTC
(In reply to comment #16)
> (Please don't set group flags when not needed. Thanks.

Ah, sorry, Fred told me the history of this bug now on IRC. Switched flags.
Comment 18 Philip Withnall 2010-09-16 09:31:02 UTC
commit 2fb2a77597bdcbe2ee18e3d5c1d0fa79ced11d2d
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Wed Sep 15 16:22:30 2010 +0100

    Add individuals to the EmpathyIndividualStore before updating them
    
    When adding a new contact _with_ an alias set, the code in
    EmpathyIndividualStore was listening to (and acting on) property notifications
    (such as alias changes) for the individual before adding the individual to the
    store, resulting in duplicate contact listings. Closes: bgo#629380

 libempathy-gtk/empathy-individual-store.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)