GNOME Bugzilla – Bug 629378
Make the .desktop files localizable
Last modified: 2010-09-16 10:24:07 UTC
Created attachment 170035 [details] [review] Fix localization problems in .desktop files I noticed that the localization of the .desktop files does not work, there are several small problems, attached patch fixes all of them. As the strings are already there, fixing this would be no string freeze break.
(In reply to comment #0) > Created an attachment (id=170035) [details] [review] > Fix localization problems in .desktop files Thanks but your patch doesn't apply cleanly over current master. Also I (and all maintainers) will appreciate it if you use `git format-patch` to prepare your patches.
Created attachment 170193 [details] [review] Second try Here it is, I just didn't noticed that a simple git diff does not include the result of a former git mv.
Pushed to git master with minor modification to git log message. > As the strings are already there, fixing this would be no string freeze break. Where is there? I don't see the strings from desktop files anywhere in the po files.
Not in the po files, but in the source. The basic idea is this: if you add a new string after freeze to the source, that is a problem: if we do not update the translation, this string might appear to users in English. We don't want to see English strings, so we have string freeze to avoid this situation. However, if the string is already in the source, marking it as translatable is not a problem, because it would certainly appear in English - but now we get a chance to translate it. Our goal is not to see "100%" written next to the software name on a web page, but to see the software actually speaking our languages - this patch helps in achieving this. So please, push it to the gnome-2-32 branch too, translators won't bite :)
(In reply to comment #4) > > So please, push it to the gnome-2-32 branch too, translators won't bite :) There is also the Hard Code Freeze in effect, I'll push this change along with some other fixes to gnome-2-32 when its over.