GNOME Bugzilla – Bug 629371
Windows aren't dimmed when coming from the overview
Last modified: 2010-09-12 09:41:16 UTC
Currently we dim the main window when a modal dialog is attached to it. This does not seem to work when the dialog is triggered from the overview though, which is inconsistent and unexpected. Reproducer: 1) open gnome-terminal 2) type "dmesg | less" 3) go to overview 4) try to close the window
Created attachment 170052 [details] [review] don't dim window previews also fix this bug:)
Review of attachment 170052 [details] [review]: Patch looks good and fixes the problem here (also not not dimming the window previews is actually a good idea). A longer commit message with some context might be better something like --- [Overview] Don't dim window previews Undim windows when going to the overview and restore their state when leaving. --- OK to commit assuming the noted changes are intentional. ::: js/ui/windowManager.js @@ +273,2 @@ _mapWindow : function(shellwm, actor) { + if (actor.get_window_type() == Meta.CompWindowType.MODAL_DIALOG You where checking whether actor is defined / non null before. "actor && actor.get_window_type() == Meta.CompWindowType.MODAL_DIALOG" ... any reason why you removed it? (i.e was it not needed anyway?) (I can't think of a reason why actor would be null here anyway) @@ +343,2 @@ _destroyWindow : function(shellwm, actor) { + while (actor.get_window_type() == Meta.CompWindowType.MODAL_DIALOG Same here.
Comment on attachment 170052 [details] [review] don't dim window previews > any reason why you removed it? (i.e was it not needed anyway?) they are useless