GNOME Bugzilla – Bug 629349
[oggdemux] extract stream tags for tagreadbin and transcoding
Last modified: 2010-12-03 13:07:27 UTC
Here's a bunch of fixes to oggdemux/flacparse for tagreadbin.
Created attachment 170016 [details] [review] oggdemux: generate tags for all types
Created attachment 170017 [details] [review] oggdemux: delay tag messages after pad activatio
Created attachment 170018 [details] [review] flacparse: trivial caps fix
Created attachment 170019 [details] [review] flacparse: delay tags push
Re. the oggdemux patch, I think the tag extraction should be done in gstoggstream.c, since tags are in header packets, and header packets are parsed there. The existing ogm stuff in chain_peer should be moved there as well IMHO. Moving to gst-plugins-base component for now, as gst-plugins is for old 0.8 bugs and no one checks those. On a side note, this is not just for tagreadbin, but useful in general, e.g. for stream extraction (flac audio into stand-alone flac) or transcoding.
(In reply to comment #5) > Re. the oggdemux patch, I think the tag extraction should be done in > gstoggstream.c, since tags are in header packets, and header packets are parsed > there. The existing ogm stuff in chain_peer should be moved there as well IMHO. Maybe, but that would be a separate bug report/patch.
(In reply to comment #5) > Re. the oggdemux patch, I think the tag extraction should be done in > gstoggstream.c, since tags are in header packets, and header packets are parsed > there. The existing ogm stuff in chain_peer should be moved there as well IMHO. > > Moving to gst-plugins-base component for now, as gst-plugins is for old 0.8 > bugs and no one checks those. > > On a side note, this is not just for tagreadbin, but useful in general, e.g. > for stream extraction (flac audio into stand-alone flac) or transcoding. Currently we are parsing only the identification header in gstoggstream.c. I think we can add the comment header parsing for ogm,vorbis and vp8 to header checking functions of each(is_header_ogm,is_header_vorbis and is_header_vp8) .
Created attachment 170291 [details] [review] patch for vorbis comment extraction * Moving the tag extraction to gstoggstream.c. * Maintaining the taglist in GstOggStream structure. * Extracting few more identification header fields as tags.
Comment on attachment 170019 [details] [review] flacparse: delay tags push See bug #631200
Comment on attachment 170018 [details] [review] flacparse: trivial caps fix See bug #631200
Some (cumulative) patches follow that refactor, extend etc tag extraction in oggdemux/oggstream as initiated by last patch.
Created attachment 173315 [details] [review] oggdemux: send stream tags after newsegment and global tags
Created attachment 173317 [details] [review] oggstream: streamline tags extraction and prevent some leaks
Created attachment 173318 [details] [review] oggdemux: plug some oggstream leaks
Created attachment 173319 [details] [review] oggstream: refactor vorbis comment packet tag extraction
Created attachment 173320 [details] [review] oggstream: use separate tag extraction vfunction
Created attachment 173321 [details] [review] oggstream: additional types tag extraction
commit 524b7c60f20336aef6266ed260134188e7102c8e Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Wed Oct 27 13:49:41 2010 +0200 oggstream: additional tag extraction ... supporting theora, flac, speex, celt. Fixes #629349. commit d5055a9f23c64a1f6b13c690e61ba70f3d50d58a Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Wed Oct 27 12:08:25 2010 +0200 oggstream: use separate tag extraction vfunction commit cc3dfd31d09f04d970a9fb9862786312694dbe87 Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Wed Oct 27 11:58:53 2010 +0200 oggstream: refactor vorbis comment tag extraction commit a4aacb9d2c3877e965fd6f9ee9c48a07cbcbec0c Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Wed Oct 27 11:16:15 2010 +0200 oggdemux: plug some oggstream leaks commit 515f33bd3bc1f4e6bd1ccad5f6d55fb592a534ec Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Wed Oct 27 10:59:03 2010 +0200 oggstream: streamline tag extraction and prevent some leaks commit 63ba9eafb13ef8b6a28a1a8baa39376eabe5bba1 Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Wed Oct 27 10:58:16 2010 +0200 oggdemux: send stream tags after newsegment and global tags commit 2319c85f469b92221dd86e9d89dda268a8a127b4 Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com> Date: Tue Sep 14 23:08:51 2010 +0300 oggdemux: perform more (vorbis comment header) tag extractions In particular, move comment header parsing to gstoggstrem.c. Thanks to Felipe Contreras. Fixes #629349 (partially).