After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629343 - [window-dim Shader] Bump GLSL version to 1.20
[window-dim Shader] Bump GLSL version to 1.20
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-11 08:54 UTC by drago01
Modified: 2010-09-11 19:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[window-dim Shader] Bump GLSL version to 1.20 (1023 bytes, patch)
2010-09-11 08:56 UTC, drago01
none Details | Review
[windowDimmer] Bump GLSL version to 1.10 (1018 bytes, patch)
2010-09-11 18:55 UTC, drago01
committed Details | Review

Description drago01 2010-09-11 08:54:49 UTC
See patch.
Comment 1 drago01 2010-09-11 08:56:07 UTC
Created attachment 170014 [details] [review]
[window-dim Shader] Bump GLSL version to 1.20

The shader currently forces GLSL 1.0 to avoid being incompatible with older hardware but is still using features not available in 1.0.

Strict compilers fail to compile the shader:

error C7506: OpenGL/ES does not define the global variable gl_TexCoord

As every hardware/driver that supports 1.0 also supports 1.20 bumping the version to fix it is safe.
Comment 2 Maxim Ermilov 2010-09-11 18:30:19 UTC
(In reply to comment #1)
> still using features not available in 1.0.
It should be there according http://www.opengl.org/registry/doc/GLSLangSpec.Full.1.10.59.pdf

> Strict compilers fail to compile the shader:
Which one?
Comment 3 drago01 2010-09-11 18:35:28 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > still using features not available in 1.0.
> It should be there according
> http://www.opengl.org/registry/doc/GLSLangSpec.Full.1.10.59.pdf

That's 1.10 not 1.0 .. in fact #version 110 is working fine too.

> > Strict compilers fail to compile the shader:
> Which one?

NVIDIA's cg complier (i.e the one shipped in the 260.19.04 driver release).
Comment 4 drago01 2010-09-11 18:55:34 UTC
Created attachment 170037 [details] [review]
[windowDimmer] Bump GLSL version to 1.10

The shader currently forces GLSL 1.0 to avoid being incompatible with older hardware but is still using features not available in 1.0.

Strict compilers fail to compile the shader:

error C7506: OpenGL/ES does not define the global variable gl_TexCoord

As every hardware/driver that supports 1.0 also supports 1.10 bumping the version to fix it is safe.

-----

Bumping to 1.10 appears to be sufficent.
Comment 5 Maxim Ermilov 2010-09-11 19:39:34 UTC
Comment on attachment 170037 [details] [review]
[windowDimmer] Bump GLSL version to 1.10

GLSL 1.10 is part of OpenGL 2.0. It have specification in opengl.org (opposite  version 1.00).
Comment 6 drago01 2010-09-11 19:42:13 UTC
Attachment 170037 [details] pushed as 687bfbb - [windowDimmer] Bump GLSL version to 1.10