After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629304 - Bad logic when Xephyr not found
Bad logic when Xephyr not found
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-10 17:22 UTC by Owen Taylor
Modified: 2010-09-22 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-shell.in: Make xephr available within the scop of run_shell (716 bytes, patch)
2010-09-22 18:28 UTC, drago01 		none Details | Review
gnome-shell.in: Make xephr available within the scope of run_shell (717 bytes, patch)
2010-09-22 18:30 UTC, drago01 		needs-work Details | Review
gnome-shell.in: Make xephr available within the scope of run_shell (998 bytes, patch)
2010-09-22 18:37 UTC, drago01 		committed Details | Review

Description Owen Taylor 2010-09-10 17:22:08 UTC 
Reported by G. Michael Carter in 

 https://bugzilla.redhat.com/show_bug.cgi?id=632663

When trying to run gnome-shell without Xephyr installed, he got:

===
gnome-shell:437:<module>:NameError: name 'xephyr' is not defined

Traceback (most recent call last):

+ Trace 223637

  • File "/usr/bin/gnome-shell", line 437 in <module> 
    if xephyr:
NameError: name 'xephyr' is not defined 
===

So it seems like we have some logic bug - probably just need a xephyr = None somewhere.
Comment 1 drago01 2010-09-22 18:28:35 UTC 
Created attachment 170853 [details] [review]
gnome-shell.in: Make xephr available within the scop of run_shell
Comment 2 drago01 2010-09-22 18:30:44 UTC 
Created attachment 170854 [details] [review]
gnome-shell.in: Make xephr available within the scope of run_shell

Fix subject (typo)
Comment 3 Owen Taylor 2010-09-22 18:35:17 UTC 
Review of attachment 170854 [details] [review]:

::: src/gnome-shell.in
@@ +305,2 @@
     normal_exit = False
+    xephyr = None

If you add this here (presumably for the case where start_xephyr() throws), then you should remove the existing xephyr = None
Comment 4 drago01 2010-09-22 18:37:10 UTC 
Created attachment 170855 [details] [review]
gnome-shell.in: Make xephr available within the scope of run_shell
Comment 5 Owen Taylor 2010-09-22 18:39:50 UTC 
Review of attachment 170855 [details] [review]:

Looks good
Comment 6 drago01 2010-09-22 18:42:24 UTC 
Attachment 170855 [details] pushed as 8591a2f - gnome-shell.in: Make xephr available within the scope of run_shell