After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629253 - Remove unnecessary markup
Remove unnecessary markup
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-09-10 11:06 UTC by Gabor Kelemen
Modified: 2013-09-13 01:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simple patch to remove unnecessary (3.76 KB, patch)
2010-09-10 11:06 UTC, Gabor Kelemen 		needs-work Details | Review
Simple patch to remove unnecessary markup (4.22 KB, patch)
2010-09-10 14:40 UTC, Gabor Kelemen 		committed Details | Review

Description Gabor Kelemen 2010-09-10 11:06:25 UTC 
Created attachment 169938 [details] [review]
Simple patch to remove unnecessary 

Some unnecessary UI markup crawled into the translatable strings of the settings capplet, please remove it.
Attached patch should fix this, altough it is untested.
Comment 1 Matthew Barnes 2010-09-10 11:37:58 UTC 
Better to use g_markup_printf_escaped() so the translatable text gets properly escaped if needed.

buff = g_markup_printf_escaped ("<span ...>%s</span>", _("Translate me!"));
Comment 2 Gabor Kelemen 2010-09-10 14:40:32 UTC 
Created attachment 169952 [details] [review]
Simple patch to remove unnecessary markup

Okay, I changed it as you asked. Also, I changed the first occurrence of this construct, which I tried to copy :).
(btw, there is one more of that in mail-settings-view.c)
Comment 3 Matthew Barnes 2010-09-10 22:36:22 UTC 
Perfect.  Patch committed for 2.31.92 with string freeze break approval from the gnome-i18n team (and I picked off the case in mail-settings-view.c).

http://git.gnome.org/browse/evolution/commit/?id=ff35bad1dec98abf76844fe661b6225b8ed4ba7b