After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629192 - g_strdup_value_contents(): dump GStrv more usefully
g_strdup_value_contents(): dump GStrv more usefully
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-09-09 16:46 UTC by Will Thompson
Modified: 2010-09-13 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Yes, I forgot the patch! :) (1.66 KB, patch)
2010-09-13 15:32 UTC, Will Thompson 		committed Details | Review

Description Will Thompson 2010-09-09 16:46:48 UTC 
Previously, dumping a GValue holding a GStrv just yielded "((GStrv *)
0xDEADBEEF)". I think it'd be more useful to dump a Python list-style
representation of the GStrv's contents, if it's not NULL.

Patch attached.
Comment 1 Matthias Clasen 2010-09-13 15:15:33 UTC 
> Patch attached.

Forgotten patch ?
Comment 2 Will Thompson 2010-09-13 15:32:51 UTC 
Created attachment 170165 [details] [review]
Yes, I forgot the patch! :)
Comment 3 Matthias Clasen 2010-09-13 16:44:55 UTC 
Review of attachment 170165 [details] [review]:

Looks good to me; you could avoid printf and use some append_c() instead, but not a big deal for a debug-only function
Comment 4 Will Thompson 2010-09-13 18:20:11 UTC 
Comment on attachment 170165 [details] [review]
Yes, I forgot the patch! :)

Thanks!