After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629177 - Do not use deprecated gtk_widget_get_child_requisition()
Do not use deprecated gtk_widget_get_child_requisition()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other All
: Normal normal
: 3.0
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-09-09 14:51 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-09-13 19:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not use deprecated gtk_widget_get_child_requisition() (29.98 KB, patch)
2010-09-09 14:52 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-09-09 14:51:55 UTC 
Use gtk_size_request_get_size() instead
Comment 1 Javier Jardón (IRC: jjardon) 2010-09-09 14:52:48 UTC 
Created attachment 169863 [details] [review]
Do not use deprecated gtk_widget_get_child_requisition()
Comment 2 Tristan Van Berkom 2010-09-10 10:16:02 UTC 
Review of attachment 169863 [details] [review]:

Wow huge patch, by looking at every file in the patch it looks good to me,
gtk_widget_get_child_requisition() is calling gtk_size_request_get_size()
for its return value anyway so there's no reason it should break anything
(ofcourse doing a regular check through gtk-demo is always a good idea).

Thanks for all the cleanup Javier !
Comment 3 Matthias Clasen 2010-09-10 11:51:14 UTC 
Yeah, big patch touching size allocation is always a bit scary.
How well has this been tested ?
Comment 4 Javier Jardón (IRC: jjardon) 2010-09-11 02:22:41 UTC 
I did some testing but, as Tristan said, there's no reason it should break anything as I've simply called the new function instead the deprecated API

See http://git.gnome.org/browse/gtk+/tree/gtk/gtkwidget.c#n3899
Comment 5 Matthias Clasen 2010-09-13 18:26:06 UTC 
I gave it some testing too, and didn't notice any problems.
So, I guess it is fine.
Comment 6 Javier Jardón (IRC: jjardon) 2010-09-13 19:27:16 UTC 
Comment on attachment 169863 [details] [review]
Do not use deprecated gtk_widget_get_child_requisition()

commit 9e81022bf6b7a5c25584b9eeea360cdf38cd6949