GNOME Bugzilla – Bug 629116
Please review strings for translation
Last modified: 2011-08-25 13:13:26 UTC
Here are some strings I struggled to translate. Please comment on the meaning of the variables in these strings ../daemon/gvfsbackendgphoto2.c:506 %s: %d: Directory or file exists (and all the ones below it) I assume the abbreviations aren't intended: ../daemon/gvfsbackendgphoto2.c:2822 ../daemon/gvfsbackendgphoto2.c:3452 Error renaming dir ../daemon/gvfsbackendgphoto2.c:3409 Not supported (src is dir, dst is dir) (and lower down in the same file) ../daemon/gvfsdaemonutils.c:104 Error sending fd: %s (or is it at least possible to explain in comments what 'fd' stands for?) The capitalisation of FTP vs. ftp is inconsistent. Maybe references to sftp should also be in all capital letters.
Ping?
String freeze is in less than 2 weeks. Can I help with this? Any further information needed? I'd love to have this fixed for GNOME 3.2.
(In reply to comment #0) > ../daemon/gvfsbackendgphoto2.c:506 > %s: %d: Directory or file exists There's the following comment in the source file: /* Translator: %s represents a more specific error message and %d the specific error code */ The first %s argument is an error string from the same source file - search for "get_error_from_gphoto2 (" and you'll see it. E.g. "Error loading device information", "Error creating file object", "Error getting file", "Error creating directory" ... > I assume the abbreviations aren't intended: > ../daemon/gvfsbackendgphoto2.c:2822 ../daemon/gvfsbackendgphoto2.c:3452 > Error renaming dir Correct. > ../daemon/gvfsbackendgphoto2.c:3409 > Not supported (src is dir, dst is dir) Also correct. > (and lower down in the same file) > ../daemon/gvfsdaemonutils.c:104 > Error sending fd: %s > (or is it at least possible to explain in comments what 'fd' stands for?) "fd" means "filedescriptor", an ID/number which corresponds to an open file. This is an internal technical information, only informing user that something has gone terribly wrong. Useful for bugreports. > The capitalisation of FTP vs. ftp is inconsistent. Maybe references to sftp > should also be in all capital letters. Yes, I would imagine we have this inconsitency all over the package. Having a patch would be certainly helpful as long as translators could have better sense in stylistics.
Created attachment 194500 [details] [review] translation fixes Would this patch help to clarify things?
Thank you for looking into this, Tomas! I think all the changes in the patch are improvements. I would personally say: the source is a directory, but the destination is an existing file I don't know if there are any serious length constraints, but translations were already going well beyond the English since they probably didn't abbreviate. I don't feel strongly about adding "the" etc. though.
Created attachment 194528 [details] [review] Fixes for (S)FTP capitalisation Here is a patch for fixing the issue with the capitalisation of FTP and SFTP. I'm not 100% sure about the very first hunk in the patch (I'm not sure if the variable will be rendered as FTP or ftp).
I just saw this as well: daemon/gvfsbackendgphoto2.c:2748 daemon/gvfsbackendgphoto2.c:3378 "Error renaming dir" programs/gvfs-tree.c:37 "Follow symlinks, mounts and shortcuts like dirs" Here I guess we can do symlinks -> symbolic links dirs -> directories I'm not 100% sure about mounts. Does that refer to mount points?
Created attachment 194595 [details] [review] translation fixes (In reply to comment #5) > Thank you for looking into this, Tomas! I think all the changes in the patch > are improvements. I would personally say: > the source is a directory, but the destination is an existing file Yeah, that looks good, please check this updated patch. > I don't know if there are any serious length constraints, but translations were > already going well beyond the English since they probably didn't abbreviate. There are no length limitations (long stories aside), no problem to be more verbose. (In reply to comment #7) > I just saw this as well: > daemon/gvfsbackendgphoto2.c:2748 daemon/gvfsbackendgphoto2.c:3378 > "Error renaming dir" Already included in my previous patch. I left the DEBUG () messages untouched, they're not visible to users. > programs/gvfs-tree.c:37 > "Follow symlinks, mounts and shortcuts like dirs" > > Here I guess we can do > symlinks -> symbolic links > dirs -> directories > I'm not 100% sure about mounts. Does that refer to mount points? Changed, yes, that refers to mount points, but I'd leave it as is. "Following mount points" just sounds strange to me, though I'm not a user.
Review of attachment 194528 [details] [review]: Looks good to me, please commit. ::: daemon/daemon-main.c @@ +88,3 @@ up = g_ascii_strup (G_STRINGIFY (DEFAULT_BACKEND_TYPE), -1); /* translators: This is the default daemon's application name, + * the %s is the type of the backend, like "FTP" */ This is a comment, not user visible at all.
Committed the capitalisation fixes in e9538c0c6313b5a995b399291e09f6ef92b58d44. The issue with the comment is that it goes out to translators to explain what will be seen. I don't know what the capitalisation of the variable is there (or if it would matter to translators). Attachment 194595 [details] looks good. Thanks!
(In reply to comment #10) > Committed the capitalisation fixes in e9538c0c6313b5a995b399291e09f6ef92b58d44. Thanks! > The issue with the comment is that it goes out to translators to explain what > will be seen. I don't know what the capitalisation of the variable is there (or > if it would matter to translators). I see, makes sense, that didn't cross my mind. > Attachment 194595 [details] looks good. Thanks! Pushed, also sent a notice to gnome-i18n@ and gnome-doc-list@ about the string change. Closing for now as it seems we have everything fixed.