After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629073 - Add smb and dns-sd schemas
Add smb and dns-sd schemas
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks: 629085
 
 
Reported: 2010-09-08 15:02 UTC by Tomas Bzatek
Modified: 2010-11-12 17:38 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
patch (3.02 KB, patch)
2010-09-08 15:02 UTC, Tomas Bzatek 		none Details | Review

Description Tomas Bzatek 2010-09-08 15:02:12 UTC 
Created attachment 169772 [details] [review]
patch

Last few things from gnome-vfs schemas, these are used in gvfs by smb/smb-browse and network backends. 

I'm not good in creating decent names for identifiers, freel free to propose better name for the "GDnsSdDisplayMode" enum and its elements. Also note that the enum is still in "org.gnome.desktop" namespace despite of schema being "org.gnome.system" - this is a limitation of automatic .h -> .schema generation by GSettings automake rules. We would probably have to split the enum to a separate header in a separate directory otherwise.
Comment 1 Vincent Untz 2010-09-09 08:09:52 UTC 
Shouldn't they be shipped by gvfs, though?
Comment 2 Tomas Bzatek 2010-09-09 08:47:02 UTC 
(In reply to comment #1)
> Shouldn't they be shipped by gvfs, though?
Maybe, it would make sense, personally I'm not aware of any other components using them.
Comment 3 Alexander Larsson 2010-09-22 09:09:51 UTC 
If they are in gvfs then any app to configure this (like setting the smb workgroup) would need to depend on gvfs. That might not be a problem though.

In fact, maybe its better to ship these in gvfs to avoid a dependency on gnome config stuff in gvfs, as non-gnome desktops use gvfs too.
Comment 4 Tomas Bzatek 2010-11-12 17:38:21 UTC 
I've committed the schemas which now live in gvfs. We do install our enums, changed name to org.gnome.system.gvfs.enums.xml to prevent clash with future global system enums.

commit 168001c43fa8d890ada7131fe0c3abdec56640e9
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Fri Nov 12 18:16:43 2010 +0100

    Add GSettings schemas