GNOME Bugzilla – Bug 629008
Add a test for Persona additions
Last modified: 2010-09-23 17:14:45 UTC
Since adding Personas to the Telepathy backend is a pretty core function of any client, we should cover it with a test. This test itself isn't too complicated, but it uncovered a handful of subtle (yet nasty) bugs. I've fixed those in the dependent bugs.
Created attachment 169734 [details] [review] Add a test for Persona additions Squashed diff of branch: http://git.collabora.co.uk/?p=user/treitter/folks.git;a=shortlog;h=refs/heads/bgo629008-persona-add-test
Review of attachment 169734 [details] [review]: Looks fine, modulo the changes necessary for fixing bug #628970 by changing BackendStore.
Created attachment 170002 [details] [review] Add a test for Persona additions (try 2) Squashed diff of branch: http://git.collabora.co.uk/?p=user/treitter/folks.git;a=shortlog;h=refs/heads/bgo629008-persona-add-test-try2
Adding some dependencies.
Review of attachment 170002 [details] [review]: Looks good.
(Mass changing milestones; please search for this phrase to delete the bug spam.)
commit 4967acd0c235dc3eb0149cfa737443926339d08c Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Mon Sep 6 13:37:53 2010 -0700 Add a test for adding Personas. Fixes bgo#629008. NEWS | 1 + tests/telepathy/Makefile.am | 3 + tests/telepathy/contact-retrieval.vala | 181 ++++++++++++++++++++++++++++++++ 3 files changed, 185 insertions(+), 0 deletions(-) commit ba73b7bbdb0ffa08611097d11a34383b714715c1 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Sep 7 22:47:59 2010 -0700 Explicitly reset the aggregator between tests. Helps bgo#629008. tests/telepathy/contact-retrieval.vala | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit b5d1c361f342a859ef35442a3672f07d3ccde844 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Tue Sep 7 16:40:05 2010 -0700 Don't deref a null PersonaStore in a failure case. Helps bgo#629008. folks/individual-aggregator.vala | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit d5fe872c623c0108de9d7afe5282bb224113d786 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Mon Sep 6 13:55:40 2010 -0700 Prepare the aggregator asynchronously (as clients will) Helps bgo#629008. tests/telepathy/contact-retrieval.vala | 24 +++++++++++++++++++++--- 1 files changed, 21 insertions(+), 3 deletions(-) commit c911b3a7dce4b564c72bafd21e972f091bdf5b00 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Fri Sep 3 17:51:31 2010 -0700 Re-use the defined protocol prefix for tests. Helps bgo#629008. tests/telepathy/contact-retrieval.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 4e0f531abd8f2ce6ebd09c0dcbda14321a5216a1 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Fri Sep 3 17:49:20 2010 -0700 Centralize the list of expected test Individuals. Helps bgo#629008. tests/telepathy/contact-retrieval.vala | 32 +++++++++++++++++++------------- 1 files changed, 19 insertions(+), 13 deletions(-)