Bug 628974 - Rhythmbox can not share to iTunes 10 using DAAP
Rhythmbox can not share to iTunes 10 using DAAP
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: DAAP
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-09-07 16:35 UTC by W. Michael Petullo
Modified: 2010-09-09 19:35 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix sharing to iTunes 10 (3.41 KB, patch)
2010-09-08 17:23 UTC, W. Michael Petullo
accepted-commit_now Details | Diff | Review

Description W. Michael Petullo 2010-09-07 16:35:37 UTC
It seems that iTunes 10 requires aeMK/com.apple.itunes.mediakind included in the response to a "GET /databases/1/items." aeMK/com.apple.itunes.mediakind has been around for a few versions of iTunes. I suspect previous versions assumed a value of 1 (Music) when its value was missing from a response. iTunes 10 is more picky, which might actually turn out better for users once the servers are fixed. 

I have been investigating this issue. Dmapd-0.0.27+libdmapsharing-2.0.2 now works with iTunes 10. Rhythmbox+libdmapsharing-2.0.2 should work once I update Rhythmbox to support the "mediakind" property in DAAPRecord. For a pretty good description of what needs to be done, see the difference between dmapd-0.0.26 and dmapd-0.0.27.

See also:

http://discussions.apple.com/thread.jspa?threadID=2564925&start=0&tstart=0
Comment 1 W. Michael Petullo 2010-09-08 17:23:49 UTC
Created attachment 169784 [details] [review]
Fix sharing to iTunes 10

iTunes 10 is more picky about com.apple.itunes.mediakind. If it is requested, it must be present in the response. This patch fixes serving to iTunes 10.
Comment 2 Jonathan Matthew 2010-09-08 22:43:41 UTC
Review of attachment 169784 [details] [review]:

OK to commit with 'DMAP_MEDIA_KIND_MUSIC' instead of '1'

::: plugins/daap/rb-daap-record.c
@@ +390,3 @@
 			ext++;
 		}
+		record->priv->mediakind = 1; /* Music, FIXME: add enum to libdmapsharing */

you seem to have added the enum to libdmapsharing now
Comment 3 W. Michael Petullo 2010-09-09 19:35:38 UTC
Fixed in Git master.

Note You need to log in before you can comment on or make changes to this bug.