After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628966 - Fix the attempted_completion_function binding in Readline
Fix the attempted_completion_function binding in Readline
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.9.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks: 629075
 
 
Reported: 2010-09-07 15:12 UTC by Philip Withnall
Modified: 2010-09-17 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the attempted_completion_function binding in Readline (848 bytes, patch)
2010-09-07 15:12 UTC, Philip Withnall 		none Details | Review
Fix the signature of CompletionFunc in Readline (1.09 KB, patch)
2010-09-07 15:38 UTC, Philip Withnall 		none Details | Review
Fix the cname of CompentryFunc in Readline (1.02 KB, patch)
2010-09-07 16:07 UTC, Philip Withnall 		none Details | Review
Fix the completion_matches binding in Readline (898 bytes, patch)
2010-09-07 16:08 UTC, Philip Withnall 		none Details | Review

Description Philip Withnall 2010-09-07 15:12:12 UTC 
Readline.attempted_completion_function is currently bound to rl_attempt_completion_function, which doesn't exist. Patch attached to fix this.
Comment 1 Philip Withnall 2010-09-07 15:12:35 UTC 
Created attachment 169676 [details] [review]
Fix the attempted_completion_function binding in Readline
Comment 2 Philip Withnall 2010-09-07 15:38:25 UTC 
Created attachment 169682 [details] [review]
Fix the signature of CompletionFunc in Readline

Here's another patch, which fixes the signature of CompletionFunc. It was attempting to add an array length parameter, which broke things completely. (rl_attempted_completion_function uses a NULL-terminated array.)
Comment 3 Philip Withnall 2010-09-07 16:07:48 UTC 
Created attachment 169683 [details] [review]
Fix the cname of CompentryFunc in Readline
Comment 4 Philip Withnall 2010-09-07 16:08:07 UTC 
Created attachment 169684 [details] [review]
Fix the completion_matches binding in Readline
Comment 5 Evan Nemerson 2010-09-17 06:06:40 UTC 
commit f5cae3c0a23e8be0b4c13a4486930a3d55bd8986
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Tue Sep 7 17:06:58 2010 +0100

    readline: fix the completion_matches binding

commit e0a4980d3413c833be0da931eafb7e8de28c3ba9
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Tue Sep 7 17:06:26 2010 +0100

    readline: fix the cname of CompentryFunc

commit 87b4b42523f130976ca548b93011b9cfa70746bd
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Tue Sep 7 16:37:00 2010 +0100

    readline: fix the signature of CompletionFunc

commit 4126f5be3f9fbdf3f15c3d088954c88006d7e8ec
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Tue Sep 7 16:10:31 2010 +0100

    readline: fix the attempted_completion_function binding
    
    Fixes bug 628966.
Comment 6 Philip Withnall 2010-09-17 10:31:46 UTC 
Any chance these could be cherry-picked to 0.10 as well? Thanks.