After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628912 - There is no such thing as a cairo
There is no such thing as a cairo
Status: RESOLVED FIXED
Product: lasem
Classification: Other
Component: DOM
git master
Other Linux
: Normal normal
: ---
Assigned To: Emmanuel Pacaud
Depends on:
Blocks:
 
 
Reported: 2010-09-06 18:19 UTC by Owen Taylor
Modified: 2010-09-12 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Owen Taylor 2010-09-06 18:19:54 UTC
void lsm_dom_view_set_cairo (LsmDomView *view, cairo_t *cr)

Is a misnomer - there is no such thing as a 'cairo' - cairo_t is a cairo context. See http://cairographics.org/manual/language-bindings.html

Suggest deprecating the old name and adding lsm_dom_view_set_cairo_context()

Or as a slightly bigger, but better, change, pass the cairo_t as a parameter to lsm_dom_view_render - the cairo context object is a transient object holding the current state of a rendering process. Setting it as an object property never really makes sense.
Comment 1 Emmanuel Pacaud 2010-09-06 19:47:26 UTC
Thanks Owen.

I'll probably dump lsm_dom_view_set_cairo and pass cairo_t to lsm_dom_view_render.
Comment 2 Emmanuel Pacaud 2010-09-12 18:09:38 UTC
Fixed in master.