After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628853 - hangs if there's no relationships.ini file
hangs if there's no relationships.ini file
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Key file backend
git master
Other Linux
: Normal critical
: gnome-2.32
Assigned To: folks-maint
folks-maint
: 629242 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-06 07:02 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2010-09-10 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix error handling in the code to create the ~/.local/share/folks directory tree (2.30 KB, patch)
2010-09-06 09:37 UTC, Philip Withnall 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2010-09-06 07:02:53 UTC 
if .local/share/folks/relationships.ini file doesn't exist, then the key file backend will eat cpu forever.

touch .local/share/folks/relationships.ini fixes the issue and lets empathy start.
Comment 1 Philip Withnall 2010-09-06 09:37:37 UTC 
Created attachment 169551 [details] [review]
Fix error handling in the code to create the ~/.local/share/folks directory tree

http://git.collabora.co.uk/?p=user/pwith/folks;a=shortlog;h=refs/heads/628853-load-relationships-ini
Comment 2 Philip Withnall 2010-09-10 09:26:32 UTC 
*** Bug 629242 has been marked as a duplicate of this bug. ***
Comment 3 Travis Reitter 2010-09-10 16:17:24 UTC 
Review of attachment 169551 [details] [review]:

Oddly, I couldn't reproduce this before apply the patch. But I couldn't after, and it seems like an improvement anyhow.
Comment 4 Philip Withnall 2010-09-10 16:18:40 UTC 
commit 88df560e88cf14e3fc6b0b6060173dd94e3ecaed
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Mon Sep 6 10:35:25 2010 +0100

    Bug 628853 — hangs if there's no relationships.ini file
    
    The code to create the directory tree for relationships.ini wasn't handling
    errors properly, so was getting stuck in an infinite loop in the case that
    the ~/.local/share/folks directory existed but relationships.ini didn't.
    Closes: bgo#628853

 backends/key-file/kf-persona-store.vala |   23 +++++++++++++++++++----
 1 files changed, 19 insertions(+), 4 deletions(-)