GNOME Bugzilla – Bug 628823
"Salut" -> "People Nearby" in the error message
Last modified: 2011-08-29 10:12:43 UTC
The result of BUG 459546 has been to change "Salut" to "People Nearby". But the error message "Don't display any dialogs if there are any non-Salut accounts" (/src/empathy-accounts.c) still use term "Salut". It's confusing.
Would ""Don't display any dialogs if there are any non 'People Nearby' accounts" be clearer?
Yes. Or: "Don't display any dialogs if there are any account of non 'People Nearby' type" ? (I'm not native English speaker so It could be incorrectly.)
Created attachment 173098 [details] [review] my patch for the bug I changed "Salut" for "People Nearby" on the error message.
Review of attachment 173098 [details] [review]: The sentence doesn't make sense. It should be something like "if there are only "People Nearby" accounts".
Created attachment 173232 [details] [review] my patch for the bug (second try) Now I fixed the grammar mistake, I am not a native english speaker, that's why I sometimes could write non sense sentences.
hmmm... it should be "there aren't only People Nearby accounts" to preserve the original sense of "if thera any non-Salut accounts" right?
Created attachment 173235 [details] [review] patch (third try)
I hope that one is right :)
Review of attachment 173235 [details] [review]: Looks good!
Created attachment 173239 [details] [review] patch ready to be commited there it is
Committed!