After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628748 - GtkContainer find_child_property() and list_child_properties()
GtkContainer find_child_property() and list_child_properties()
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-09-04 01:57 UTC by Kevin Ryde
Modified: 2010-10-30 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
diff incl test case (6.85 KB, patch)
2010-09-04 01:57 UTC, Kevin Ryde
committed Details | Review

Description Kevin Ryde 2010-09-04 01:57:24 UTC
Created attachment 169460 [details] [review]
diff incl test case

This is a few lines to wrap gtk_container_class_find_child_property() and gtk_container_class_list_child_properties().

It's adapted from the corresponding GObject code and a bit of sharing with it might be possible in the future.

I've got it setup to croak on a non-container, which is unlike the GObject bit giving empty/undef.  As long as an @ISA is sensible then I suppose the code isn't reached for a non-object/non-container anyway, so it probably doesn't matter much what it does for that case.  Starting strictly with a croak could always be loosened in the future.
Comment 1 Torsten Schoenfeld 2010-09-19 16:56:23 UTC
Terrific patch!  Committed.  Thanks.
Comment 2 Kevin Ryde 2010-09-21 00:04:49 UTC
I see I did something wrong to the apidoc bit

    =for apidoc Gtk2::Container::list_child_properties

which doesn't come out in final pod.  What should it look like for one of these dual ALIAS func thingies?  (I thought I copied what GObject.xs had ...)
Comment 3 Torsten Schoenfeld 2010-10-30 18:08:51 UTC
Some experimentation suggests that the '=for apidoc' line needs to match the ALIAS line completely in order for Glib::GenPod to pick up the POD.  I haven't investigated much further, but I just fixed this particular instance.