After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628747 - gst-plugins-base: unable to build because of compiler warning in libggsttag
gst-plugins-base: unable to build because of compiler warning in libggsttag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-04 00:57 UTC by Leo Singer
Modified: 2010-09-04 07:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (869 bytes, patch)
2010-09-04 00:57 UTC, Leo Singer 		committed Details | Review

Description Leo Singer 2010-09-04 00:57:05 UTC 
Created attachment 169459 [details] [review]
Proposed patch

I am unable to build gst-plugins-base because of a compiler warning.  The warning is

cc1: warnings being treated as errors
gstexiftag.c: In function 'exif_reader_read_rational_tag':
gstexiftag.c:1228: warning: 'aux_n' may be used uninitialized in this function
gstexiftag.c:1228: warning: 'aux_d' may be used uninitialized in this function
gstexiftag.c:1204: warning: 'frac_n' may be used uninitialized in this function
gstexiftag.c:1205: warning: 'frac_d' may be used uninitialized in this function

The attached patch silences the warning and allows the build to proceed.

My compiler says that it is gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-46).
Comment 1 Sebastian Dröge (slomo) 2010-09-04 07:08:27 UTC 
Please attach patches in "git format-patch" format in the future.


commit fecb764e2ffcff19302871fd63da9a0e239083f3
Author: Leo Singer <lsinger@caltech.edu>
Date:   Sat Sep 4 09:06:08 2010 +0200

    exiftag: Fix compiler warnings with old gcc versions
    
    Old gcc complains about possibly uninitialized variables which
    are always initialized before usage in reality. Fixes bug #628747.