After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628713 - Configure fails when mm-common is not installed.
Configure fails when mm-common is not installed.
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: documentation
2.90.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2010-09-03 16:01 UTC by Patricia Santana Cruz
Modified: 2011-01-31 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that fixes this problem. (1.16 KB, patch)
2010-09-03 16:01 UTC, Patricia Santana Cruz 		needs-work Details | Review

Description Patricia Santana Cruz 2010-09-03 16:01:32 UTC 
Created attachment 169439 [details] [review]
Patch that fixes this problem.

To reproduce:
Check out git master.
Make sure mm-common is not installed.
Run ./autogen.sh

Actual results:
./configure: line 3564: syntax error near unexpected token `GTHREAD_CFLAGS,'
./configure: line 3564: `MM_PKG_CONFIG_SUBST(GTHREAD_CFLAGS, --cflags-only-other gthread-2.0)'

Expected results:
Autogen should complain that it does not find mm-common.
Comment 1 Murray Cumming 2010-09-03 16:08:43 UTC 
How could mm-common-prepare work if mm-common is not installed?
Comment 2 David King 2010-09-03 16:26:43 UTC 
(In reply to comment #1)
> How could mm-common-prepare work if mm-common is not installed?

It would fail, but at least during autogen rather than configure. The error message is also more useful than the output from configure (mm-common-prepare: command not found).
Comment 3 David King 2010-09-03 17:07:04 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > How could mm-common-prepare work if mm-common is not installed?
> 
> It would fail, but at least during autogen rather than configure. The error
> message is also more useful than the output from configure (mm-common-prepare:
> command not found).

However, on looking at the mm-common-prepare script, it seems that it does not copy the macros (this is left to aclocal), so just mentioning the dependency on mm-common in the README would be sufficient.
Comment 4 David King 2010-09-03 17:09:25 UTC 
Comment on attachment 169439 [details] [review]
Patch that fixes this problem.

The patch could be changed to run mm-common-prepare with the --version argument, as then a failure would indicate lack of an mm-common installation.
Comment 5 Murray Cumming 2010-09-03 19:22:00 UTC 
(In reply to comment #4))
> The patch could be changed to run mm-common-prepare with the --version
> argument, as then a failure would indicate lack of an mm-common installation.

Sounds good to me. Feel free to commit such a change.

It's not pretty, but I guess it's unusual anyway to use extra external m4 macros.