GNOME Bugzilla – Bug 628601
Untranslated strings in IM account setting dialog
Last modified: 2010-09-02 13:37:47 UTC
Created attachment 169338 [details] screenshot of the dialog with untranslated strings While I added an new account to empathy, I noticed there are some untranslated strings in the dialog. 1. Launch the account setting dialog by Edit->Accounts-> Add... 2. Choose different protocols and check the strings "Account:" and "Password:" In the beginning, I think those two strings were not in the po file, but the strings actually exist in zh_TW.po and are translated. After tracing the source code, it seems g_strdup_printf() is not aware of the translations, so the strings were not replaced with the translated strings.
Created attachment 169340 [details] [review] proposed patch I moved _() from g_strdup_printf() to gtk_lable_new(), and it works for me.
Created attachment 169341 [details] After applying the patch
An additional remark: this issue happens on the protocols which uses the generic widget, such as zephyr, Yahoo! Japan, sipe, simple, silc, sametime, myspace, and gadugadu. The protocol with a specific widget ui file like Jabber doesn't have this issue.
Review of attachment 169340 [details] [review]: This is actually the wrong way to fix that. I have a branch providing a better fix.
Created attachment 169350 [details] [review] http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/translate-param-628601 libempathy-gtk/empathy-account-widget.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)
Created attachment 169352 [details] [review] http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/translate-param-628601 libempathy-gtk/empathy-account-widget.c | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-)
Branch has been reviewed. I'll merge it once I got the approval of the translation team.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.