GNOME Bugzilla – Bug 628589
Notification message list message is too long
Last modified: 2010-09-20 10:58:27 UTC
Dear Developers, Now, following long message are presented in learning mode and Orca preferences/keybingings page with related to notification message list mode feature: #. Translators: Orca can enable the notification messages #. list mode when the user presses a shortcut key. #. #: ../src/orca/notification_messages.py:98 msgid "" "Enable notification message list mode. Press Escape to exit or h for help" This is a very long message. For example, the hungarian translation with this message are following: msgstr "" "Értesítés listázó mód engedélyezése. A kilépéshez nyomja meg az Escape " "billentyűt, a segítségért a h billentyűt." I attaching next comment a patch with shortest this message, if my english is not good, please correct. Attila
Created attachment 169321 [details] [review] This patch possible fix this bug, please look. Joanie, this patch shortest the long notification message list keybinging and learning mode message with a shortest message. If my english message is not good, please correct my message. Attila
Attila, thanks. I'm not sure what to do here. Ale had pointed out this issue to me. The problem is that we need some way to be sure the user knows how to use and how to get out of this mode. Just like with Orca+H. So we left it as José had it. CCing both Ale and José so they can chime in.
Not possible to do similar way with keyboard shortcuts list feature message separation? For example, my short message is enough with Orca keybindings page (need an absolute short message), but if the user press the user defined shortcut key, need present a longest message to notify the user how can use this feature. This feature is an absolute useful and wished feature, I am very happy when I see this feature. For example, when the user activate this function, the original longest message is very good. If the user press the h key after this message, he or she see detailed informations (navigation keys instructions), this is absolute right and done. Attila
(In reply to comment #3) > Not possible to do similar way with keyboard shortcuts list feature message > separation? > For example, my short message is enough with Orca keybindings page (need an > absolute short message), but if the user press the user defined shortcut key, > need present a longest message to notify the user how can use this feature. > This feature is an absolute useful and wished feature, I am very happy when I > see this feature. > > For example, when the user activate this function, the original longest message > is very good. If the user press the h key after this message, he or she see > detailed informations (navigation keys instructions), this is absolute right > and done. > > Attila Hi. When user press the key to enter in the list mode, a short message is spoken telling the number of messages, and instructing the user to press h for help. How about showing the help instead of this short message?
(In reply to comment #4) > When user press the key to enter in the list mode, a short message is spoken > telling the number of messages, and instructing the user to press h for help. > How about showing the help instead of this short message? And by doing so, not introduce any string changes for which I will have to ask for permission to break string freeze? That would have my vote. <smile>
(In reply to comment #5) > (In reply to comment #4) > > When user press the key to enter in the list mode, a short message is spoken > > telling the number of messages, and instructing the user to press h for help. > > How about showing the help instead of this short message? > > And by doing so, not introduce any string changes for which I will have to ask > for permission to break string freeze? That would have my vote. <smile> Seems to me that we need to apply the patch attached in comment #2. No more strings will be changed.
Now already string freeze, or near it? Jose, the problem only the long message is presenting the Enable notification message list mode. Press Escape to exit or h for help" with Orca preferences/keybindings page. Need shorting this feature learning mode and Orca preferences/keybindings page message, and perhaps next developing cicle insert this long message when the user activate this feature. But if this is not good ydea, I accept of course. Attila
Created attachment 169377 [details] [review] revision #1 Implements Attila's suggestion. Moreover, when the user enters the list mode, the help is spoken. The help was already present in the scripts and I didn't need to include new strings.
Jose, your patch is perfect I think, I tested. Joanie, this fix method is good? Attila
This bit here looks like a new string as I do not see it amongst the current strings marked for translation in Orca: + _("Present notification messages list")) If this is indeed a new string, getting that in would require that we request a freeze break. Thoughts?
Joanie, if possible, I accept request freeze break, because this is a need change. If this is impossible, I don't no how can possible fix this bug now with this next stable version. Very need this message shorting if this is possible I think. If this is impossible, because not accept the freeze break request, I think we possible fix this bug only next development version if anybody not have another ydea to fix this bug.
Permission to break the string freeze requested.
We received the requisite approvals. I will make this change later today.
Review of attachment 169377 [details] [review]: Committed. I will send the appropriate teams the announcement. http://git.gnome.org/browse/orca/commit/?id=8ca3e9241ca1170a500907d56bbce7c15921b1cc