After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628500 - videotestsrc: add moving color bars pattern
videotestsrc: add moving color bars pattern
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-01 12:28 UTC by Thijs Vermeir
Modified: 2010-09-15 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videotestsrc: add moving color bars pattern (13.79 KB, patch)
2010-09-01 12:28 UTC, Thijs Vermeir
none Details | Review
videotestsrc: add moving color bars pattern (6.89 KB, patch)
2010-09-01 13:20 UTC, Thijs Vermeir
needs-work Details | Review
updated patch (6.75 KB, patch)
2010-09-06 06:01 UTC, David Schleef
committed Details | Review

Description Thijs Vermeir 2010-09-01 12:28:29 UTC
This pattern is moving the color bars with a given
speed. Negative speed is inverting the moving direction.
Comment 1 Thijs Vermeir 2010-09-01 12:28:31 UTC
Created attachment 169244 [details] [review]
videotestsrc: add moving color bars pattern
Comment 2 Tim-Philipp Müller 2010-09-01 12:40:50 UTC
Any chance you could make a patch without unrelated style/indentation fixes?

(Please don't run gst-indent on header files, in case that's what caused these)
Comment 3 Thijs Vermeir 2010-09-01 13:20:18 UTC
Created attachment 169252 [details] [review]
videotestsrc: add moving color bars pattern

This pattern is moving the color bars with a given
speed. Negative speed is inverting the moving direction.
Comment 4 Thijs Vermeir 2010-09-01 13:21:47 UTC
Indeed, updated without gst-indent on header files...
Comment 5 David Schleef 2010-09-03 20:33:26 UTC
What is this pattern meant to test?

You can get a similar effect using 'videotestsrc pattern=zone-plate kx=10 kt=-10'
Comment 6 Thijs Vermeir 2010-09-05 14:02:46 UTC
(In reply to comment #5)
> What is this pattern meant to test?

This pattern is used here to test display controllers, displays and projectors. And can reveal different types of bugs.

> You can get a similar effect using 'videotestsrc pattern=zone-plate kx=10
> kt=-10'

well, it's similar in the way that it moves. The rest of the characteristics of the pattern look pretty different...
Comment 7 David Schleef 2010-09-05 20:26:41 UTC
(In reply to comment #6)
> This pattern is used here to test display controllers, displays and projectors.
> And can reveal different types of bugs.

That's not very specific.

In any case, I would prefer to see horizontal/vertical speed added as a property to all the patterns (or rather, all the patterns where it's easy or useful), rather than add a new pattern.

As a side note, in the near future, I'm planning to convert all the pattern painting to work on a single AYUV/ARGB scanline, and then have a separate conversion to the final format.  Among other things, this would make scrolling patterns a nearly trivial offset adjustment between painting and conversion.
Comment 8 David Schleef 2010-09-05 20:32:25 UTC
Review of attachment 169252 [details] [review]:

Scrolling speed should work with all patterns.

"moving-speed" should be "horizontal-speed".

The new pattern should be called smpte100.
Comment 9 David Schleef 2010-09-06 06:01:28 UTC
Created attachment 169545 [details] [review]
updated patch

Fix conflicts that were caused by me hacking on videotestsrc today.
Comment 10 Thijs Vermeir 2010-09-09 15:08:11 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > This pattern is used here to test display controllers, displays and projectors.
> > And can reveal different types of bugs.
> 
> That's not very specific.

We use it to test synchronization, stitching, content/frame/genlock, ...
(sharp borders of the pattern are needed for this)

I will split it in parts:
- add spte100 pattern
- add horizontal-speed property
- implement horizontal-speed for spte100

On request here they also use a test-pattern with a white moving bar (on black background), are you interested in this? or can this already be done with a different pattern.
Comment 11 David Schleef 2010-09-09 19:18:02 UTC
(In reply to comment #10)
> We use it to test synchronization, stitching, content/frame/genlock, ...
> (sharp borders of the pattern are needed for this)

Ok, thanks.  That makes more sense.

> On request here they also use a test-pattern with a white moving bar (on black
> background), are you interested in this? or can this already be done with a
> different pattern.

Adding this sounds like a good idea.  Should be foreground over background color, though, which defaults to white/black.
Comment 12 David Schleef 2010-09-11 06:48:02 UTC
This patch is now on my list of things to push, once I've done some more testing.
Comment 13 David Schleef 2010-09-15 07:11:11 UTC
And has now been pushed.