After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628410 - Add support for object toolkits
Add support for object toolkits
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.31.x
Other All
: Normal normal
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
3.0!
Depends on:
Blocks: Andalucia
 
 
Reported: 2010-08-31 11:10 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2010-09-20 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (9.74 KB, patch)
2010-08-31 11:13 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2010-08-31 11:10:18 UTC 
Some toolkits now expose the toolkit as an AtkObject Attribute. Doing so allows us to handle cases where multiple toolkits are in an application.

For instance consider Epiphany: The application widgets are Gtk+. As a result, the default script (which fails back on the Gail toolkit) should be used when in menus, trying to read the status bar, etc. However, the content being displayed uses a different toolkit. If we fall back on Gail, we will do the wrong thing. :-(

At the moment in Orca, we *always* get the toolkit by asking the accessible application for it. Thus in Epiphany the Gtk+ application reports Gail. If we first look for the AtkObject Attribute and use that toolkit if it is reported, we can handle each AtkObject correctly.

focus_tracking_presenter.py will need to be modified to accomplish this.
Comment 1 Joanmarie Diggs (IRC: joanie) 2010-08-31 11:13:36 UTC 
Created attachment 169153 [details] [review]
proposed fix

This patch should do the trick. Given the nature/location of the change, it needs to be regression tested. I will do that now.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-08-31 14:48:02 UTC 
Passed all of the regression tests I was able to run. (OOo, gtk-demo, subset of the Firefox 4.0 tests). Plus some additional manual testing, including Firefox.

I was not able to run the java tests because something isn't set up correctly with my java atk wrapper in Maverick. Thus even with Accerciser, the SwingSet2 demo causes CORBA errors to be spit up.

Ale: I believe this patch is sound. And it's required in order for us to provide access to WebKitGtk content (Epiphany, Yelp 3.0, and -- I believe -- Gwibber) Therefore I'd like to commit this to master, *assuming you think it is sound to do so*. Please review and let me know.

Thanks!
Comment 3 Alejandro Leiva 2010-09-03 08:43:33 UTC 
Review of attachment 169153 [details] [review]:

Good for me.
Comment 4 Joanmarie Diggs (IRC: joanie) 2010-09-03 08:50:54 UTC 
Comment on attachment 169153 [details] [review]
proposed fix

(In reply to comment #3)
> Review of attachment 169153 [details] [review]:
> 
> Good for me.

Thanks Ale! Committed to master.

http://git.gnome.org/browse/orca/commit/?id=adacc221f267917f46d0c3dd82f258be99491248