After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628380 - Link dialog's "Link" button should be renamed "Apply"
Link dialog's "Link" button should be renamed "Apply"
Status: RESOLVED WONTFIX
Product: empathy
Classification: Core
Component: Meta Contacts
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-30 23:14 UTC by Travis Reitter
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Travis Reitter 2010-08-30 23:14:55 UTC
Since this isn't a message dialog and action isn't taken until the button is clicked, this button would be better named "Apply".

Adjusting the string now requires approval from the i10n team and notification
to the Release Team and Documentation Team.
Comment 1 Guillaume Desmottes 2010-08-31 07:50:24 UTC
Agreed.
Comment 2 Philip Withnall 2010-08-31 11:43:07 UTC
I'm not so sure. The linking dialogue is an explicit-apply window which, according to the HIG[1], should have an "OK" and an "Apply" button, with the "OK" button doing what the "Link" button does now. The "Apply" button should do what the "Link" button does now, but not close the dialogue.

Regardless, I think "Link" is better, since it's more specific than "OK" (or "Apply").

[1]: http://library.gnome.org/devel/hig-book/nightly/windows-utility.html.en#windows-explicit-apply
Comment 3 Philip Withnall 2010-08-31 17:08:50 UTC
As discussed on IRC, this isn't going to happen. See bug #628376, comment #5 for details.