After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628377 - Context menu name "Link…" is ambiguous
Context menu name "Link…" is ambiguous
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Meta Contacts
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on: 628376
Blocks:
 
 
Reported: 2010-08-30 22:53 UTC by Travis Reitter
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change “Link…“ to “Link Contacts…“ in the individual menu (1.37 KB, patch)
2010-09-01 10:20 UTC, Philip Withnall
committed Details | Review

Description Travis Reitter 2010-08-30 22:53:24 UTC
It'd be better as "Link contacts…" if the Link dialog remains only for linking or "Linked contacts" if we adjust it to also support unlinking (see bug #628376).

Adjusting the string now requires approval from the i10n team and notification to the Release Team and Documentation Team.
Comment 1 Guillaume Desmottes 2010-08-31 07:47:44 UTC
I'd vote to move unlinking to this dialog and rename to "Linked contacts".
Comment 2 Philip Withnall 2010-08-31 11:45:00 UTC
I'd vote to keep linking and unlinking separate, and change the menu entry to "Link Contacts…" (note capitalisation). I'll post my thoughts about keeping linking/unlinking separate in bug #628376.
Comment 3 Philip Withnall 2010-08-31 17:07:52 UTC
As discussed on IRC, we're going ahead with this change.
Comment 4 Philip Withnall 2010-09-01 10:20:29 UTC
Created attachment 169223 [details] [review]
Change “Link…“ to “Link Contacts…“ in the individual menu

http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/628377-link-menu-entry
Comment 5 Guillaume Desmottes 2010-09-01 10:22:31 UTC
Review of attachment 169223 [details] [review]:

Looks good.
Comment 6 Philip Withnall 2010-09-01 11:25:45 UTC
Freeze break request sent.
Comment 7 Philip Withnall 2010-09-06 09:42:38 UTC
Permission from the release team: http://mail.gnome.org/archives/release-team/2010-September/msg00011.html.

commit bd7e5e9972f45cfcf426e18cc9915bdacc8355b4
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Wed Sep 1 10:24:44 2010 +0100

    Change “Link…” to “Link Contacts…” in the individual menu
    
    This makes it clearer what the menu entry does, making linking more
    discoverable. Closes: bgo#628377

 libempathy-gtk/empathy-individual-menu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)