After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628270 - [VFuncBlob] Unknown struct offset should be 0xFFFF
[VFuncBlob] Unknown struct offset should be 0xFFFF
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-08-29 20:51 UTC by Steve Frécinaux
Modified: 2015-02-07 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[VFuncBlob] Unknown struct offset should be 0xFFFF (1.01 KB, patch)
2010-08-29 20:51 UTC, Steve Frécinaux
committed Details | Review

Description Steve Frécinaux 2010-08-29 20:51:47 UTC
When the struct offset is unknown, it is currently set to 0 instead of 0xFFFF, which is the value specified by the documentation. This is a problem as it is a legal value.
Comment 1 Steve Frécinaux 2010-08-29 20:51:49 UTC
Created attachment 169016 [details] [review]
[VFuncBlob] Unknown struct offset should be 0xFFFF

Documentation says about g_vfunc_get_offset():

 "Obtain the offset of the function pointer in the class struct.
  The value 0xFFFF indicates that the struct offset is unknown."

But g-ir-compiler did set the value to 0 when the offset is unknown.
This patch fixes it.
Comment 2 Johan (not receiving bugmail) Dahlin 2010-09-06 04:12:41 UTC
Review of attachment 169016 [details] [review]:

This should be okay, as far as I know no bindings use GIVFuncInfo yet.
Comment 3 Steve Frécinaux 2010-09-06 06:33:58 UTC
Attachment 169016 [details] pushed as f1a4bb9 - [VFuncBlob] Unknown struct offset should be 0xFFFF
Comment 4 André Klapper 2015-02-07 16:50:35 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]