After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628202 - Miscellaneous string fixes
Miscellaneous string fixes
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Zeeshan Ali
Depends on:
Blocks:
 
 
Reported: 2010-08-28 17:27 UTC by Philip Withnall
Modified: 2010-08-30 22:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove markup from a translatable string (1.29 KB, patch)
2010-08-28 17:29 UTC, Philip Withnall 		committed Details | Review
Don't build translatable strings by substitution (1.05 KB, patch)
2010-08-28 17:30 UTC, Philip Withnall 		committed Details | Review
Miscellaneous string fixes (7.40 KB, patch)
2010-08-28 17:30 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2010-08-28 17:27:50 UTC 
Three patches attached for some issues I found with Rygel's translatable strings when doing the en_GB translation.
Comment 1 Philip Withnall 2010-08-28 17:29:38 UTC 
Created attachment 168955 [details] [review]
Remove markup from a translatable string

See http://live.gnome.org/GnomeGoals/RemoveMarkupInMessages.
Comment 2 Philip Withnall 2010-08-28 17:30:29 UTC 
Created attachment 168956 [details] [review]
Don't build translatable strings by substitution

The words "start" and "stop" may affect the conjugation of other words in the string in languages other than English. This patch isn't tested, but should work.
Comment 3 Philip Withnall 2010-08-28 17:30:54 UTC 
Created attachment 168957 [details] [review]
Miscellaneous string fixes

Miscellaneous string fixes, mostly fixing punctuation problems.
Comment 4 Zeeshan Ali 2010-08-30 12:01:46 UTC 
We are in string freeze so I guess these changes will have to wait until after we have branched for GNOME 2.32?
Comment 5 Philip Withnall 2010-08-30 12:23:04 UTC 
String freeze starts at midnight tonight (UTC)[1]; we're only in the string change notification period at the moment, so these can be committed if you send a notification to the gnome-i18n ML.

[1]: (See "Important information for module maintainers" here: http://live.gnome.org/TwoPointThirtyone.)
Comment 6 Zeeshan Ali 2010-08-30 13:07:36 UTC 
Hmm.. I've merged your patches already and sent the notification to gnome-i18n. However, don't you agree that translators will not get any time to update the already translated strings before I make the release tonight?
Comment 7 Philip Withnall 2010-08-30 13:16:10 UTC 
(In reply to comment #6)
> Hmm.. I've merged your patches already and sent the notification to gnome-i18n.
> However, don't you agree that translators will not get any time to update the
> already translated strings before I make the release tonight?

That's true, but they've got another two weeks (and two releases) before 2.32.0.
Comment 8 Zeeshan Ali 2010-08-30 22:03:21 UTC 
Fixed in git master, thanks for your patches.