After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628183 - Rework the way search paths are defined in PeasEngine
Rework the way search paths are defined in PeasEngine
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-28 12:54 UTC by Steve Frécinaux
Modified: 2010-10-02 23:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PeasEngine] Compute the plugin file extension once and for all. (3.72 KB, patch)
2010-08-28 12:54 UTC, Steve Frécinaux 		committed Details | Review
[PeasEngine] Add peas_engine_append_search_path() (11.98 KB, patch)
2010-08-28 12:54 UTC, Steve Frécinaux 		committed Details | Review

Description Steve Frécinaux 2010-08-28 12:54:27 UTC 
This drops the construct property and use a method instead.
Comment 1 Steve Frécinaux 2010-08-28 12:54:29 UTC 
Created attachment 168943 [details] [review]
[PeasEngine] Compute the plugin file extension once and for all.
Comment 2 Steve Frécinaux 2010-08-28 12:54:33 UTC 
Created attachment 168944 [details] [review]
[PeasEngine] Add peas_engine_append_search_path()

This new API replaces the old "search-path" construct property. It
is more understandable and can be used after object construction.
Comment 3 Ignacio Casal Quinteiro (nacho) 2010-09-24 18:38:49 UTC 
Review of attachment 168943 [details] [review]:

This looks good to me.
Comment 4 Ignacio Casal Quinteiro (nacho) 2010-09-24 18:42:01 UTC 
Review of attachment 168944 [details] [review]:

Looks good, though maybe I'd remove that comment.

::: libpeas/peas-engine.c
@@ +236,1 @@
+  /* Appending to a list is bad, but is easier to handle wrt refreshing

I don't think this is bad, we are not going to have like a hundred items here.
Comment 5 Steve Frécinaux 2010-10-02 23:17:37 UTC 
Attachment 168943 [details] pushed as 00f05ee - [PeasEngine] Compute the plugin file extension once and for all.
Attachment 168944 [details] pushed as d4cacb9 - [PeasEngine] Add peas_engine_append_search_path()