After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628127 - jpeg rtp payloader crashes when there is corruption in the jpeg byte stream.
jpeg rtp payloader crashes when there is corruption in the jpeg byte stream.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.16
Other Windows
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-27 13:50 UTC by American Dynamics
Modified: 2010-09-07 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for modified code. (1.83 KB, patch)
2010-08-27 13:50 UTC, American Dynamics
none Details | Review

Description American Dynamics 2010-08-27 13:50:25 UTC
Created attachment 168878 [details] [review]
Patch for modified code.

We have found that the jpeg rtp payloader element will crash when we simulate random corruption in the JPEG byte stream.  We need the jpeg rtp payloader to be more robust to byte stream corruption so we have coded up additional checks around the number and the size of the quantization tables in the JPEG byte stream.
Comment 1 Wim Taymans 2010-09-07 14:53:39 UTC
Thanks. commited an additional patch of mine that does some more checks and cleans up the other check.

commit 2ed53fd77fb2c7860f8919822b70abc703909f4a
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue Sep 7 16:40:08 2010 +0200

    rtpjpegpay: do some more sanitity checks
    
    Protect some more against invalid input.

commit a482677a145b0504da13367db8126ec650dc7a82
Author: American Dynamics <GStreamer-Bugs at tycosp.com>
Date:   Tue Sep 7 15:20:12 2010 +0200

    jpegpay: handle corrupted jpeg better
    
    Protect against corrupted jpeg input.