GNOME Bugzilla – Bug 628093
[patch] Unminimized windows don't always get mapped
Last modified: 2018-02-01 04:39:41 UTC
Created attachment 168860 [details] [review] Fixes bug where unminimized windows are sometimes not mapped Unity redecorates window (at some point, does not matter) Mutter marks the window as "redecorating" in mutter-window.c Mutter never unmarks the window as "redecorated", thus causing effects to never be triggered on events No event trigger results in no window mapping From: https://launchpad.net/bugs/620758
Comment on attachment 168860 [details] [review] Fixes bug where unminimized windows are sometimes not mapped This patch is not correct, if for no other reason that it removes the only use of a flag without removing the flag; also, the flag addresses a real issue, see commit fb1fc4e7c6eb673a464262874f6c97e8907ca495, it can't just be removed. The redecorating flag itself does not stop window from getting shown, only from an effect being run during the show. Reading the launchpad description, it looks like the minimize effect is not finished correctly, which would likely be a bug in the unity mutter plugin (e.g., not restoring the MutterWindow to it's correct state when the minimize effect finishes).
The fix was never intended to come upstream, sorry. It was a last ditch effort to figure out why clutter does not unmark the redecorating bool. I have checked the event accounting on the minimize event and there does not seem to be any obvious issues. I did not bother attempting to clean up the bool because I have always assumed this would trigger bugs (hopefully less annoying than being unable to unminimize windows) hoping later I could figure out a real fix for the problem. I am able to reproduce the issue using gnome shell and a program to undecorate/redecorate windows.
Patch not used downstream anymore, so I assume a fix is not needed.