After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628079 - Use libchamplain 0.7.1 or newer for the map plugin
Use libchamplain 0.7.1 or newer for the map plugin
Status: RESOLVED FIXED
Product: eog-plugins
Classification: Core
Component: general
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-26 22:34 UTC by Jiri Techet
Modified: 2019-02-22 03:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (862 bytes, patch)
2010-08-26 22:36 UTC, Jiri Techet 		accepted-commit_now Details | Review

Description Jiri Techet 2010-08-26 22:34:45 UTC 
The attached patch makes the map eog plugin use libchamplain 0.7.1 as discussed here:
http://mail.gnome.org/archives/desktop-devel-list/2010-August/msg00051.html
Comment 1 Jiri Techet 2010-08-26 22:36:43 UTC 
Created attachment 168849 [details] [review]
Patch
Comment 2 Felix Riemann 2010-08-28 17:43:26 UTC 
Review of attachment 168849 [details] [review]:

Thanks! Looks trivial enough to me. ;)
Comment 3 Claudio Saavedra 2010-08-29 20:53:57 UTC 
Is this really necessary? Is there anything in the plugin that really requires 0.7.1 ?
Comment 4 Jiri Techet 2010-08-29 23:25:52 UTC 
It's not necessary API-wise but because the version was bumped in jhbuild, eog-plugins wouldn't build because libchamplain puts the library version into the soname. The configure.ac checks look like

champlain-0.4 >= 0.4

and the new library will be champlain-0.8 so the above condition would not find the new library.
Comment 5 Claudio Saavedra 2010-08-29 23:27:28 UTC 
ok, then please go ahead.
Comment 6 Jiri Techet 2010-08-30 21:47:46 UTC 
Pushed to master.