After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628038 - AppleDevice sets Drm/Protected attribute on all songs
AppleDevice sets Drm/Protected attribute on all songs
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - iPod
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 626923 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-08-26 14:28 UTC by Gabriel Burt
Modified: 2010-08-29 20:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix a marshalling issue (1.72 KB, patch)
2010-08-26 15:21 UTC, Alan McGovern
committed Details | Review

Description Gabriel Burt 2010-08-26 14:28:05 UTC
When my iPod is loaded by the AppleDevice dap backend, all songs have the Protected attribute, which is set here:

if (track.DRMUserID > 0) {
    PlaybackError = StreamPlaybackError.Drm;
}

in src/Dap/Banshee.Dap.AppleDevice/Banshee.Dap.AppleDevice/AppleDeviceTrackInfo.cs

Printing out those DRMUserID values, they seem sequential (1 - 149, for 149 tracks).  Probably an issue in libgpod then?
Comment 1 Alan McGovern 2010-08-26 15:21:00 UTC
Created attachment 168814 [details] [review]
Patch to fix a marshalling issue

The attached patch fixes this issue and several others. We were treating a 4 byte field as being a 1 byte field which meant that every time we accessed a property declared *after* the "transferred" property, we were reading/writing to it with a 3 byte offset.
Comment 2 Christophe Fergeau 2010-08-26 20:46:32 UTC
*** Bug 626923 has been marked as a duplicate of this bug. ***
Comment 3 Christophe Fergeau 2010-08-26 21:00:03 UTC
Comment on attachment 168814 [details] [review]
Patch to fix a marshalling issue

I pushed it to libgpod git