GNOME Bugzilla – Bug 627992
dtmfsrc doesn't support gst_element_send_event
Last modified: 2010-09-06 11:42:29 UTC
The doc says to use gst_element_send_event on the pipeline, but if we are to call it on the element itself, it doesn't work. This patch will make the dtmfsrc support receiving events through gst_element_send_event when it's called directly on it. Patch available here : http://git.collabora.co.uk/?p=user/kakaroto/gst-plugins-bad.git;a=commitdiff;h=98d2c94f7430f977c9c0a4a48001a36549e20e99
This looks good, will commit after freeze.
send_event() defaults to sending to a random pad of the correct direction so this shouldn't be necessary
(In reply to comment #2) > send_event() defaults to sending to a random pad of the correct direction so > this shouldn't be necessary basesrc overrides the default handler and ignores CUSTOM events, so you need to manually override for now (also see FIXME in basesrc).
> This looks good, will commit after freeze. That would be now
Committed: commit 9823b9358e1a188dafb43fc29f00fa81e1745ced Author: Youness Alaoui <youness.alaoui@collabora.co.uk> Date: Thu Aug 26 02:54:55 2010 -0400 dtmfsrc: Make the dtmfsrc accept events sent with gst_element_send_event The doc says to use gst_element_send_event on the pipeline, but if we are to call it on the element itself, it's a noop. This should make it handle the event properly before delegating it to basesrc.