GNOME Bugzilla – Bug 627973
introspection: Split off private sources
Last modified: 2012-04-18 15:31:52 UTC
SImilarly to how gtk-doc requires IGNORE_HFILES, split off the "private" sources which we don't want to scan into separate makefile variables.
Created attachment 168755 [details] [review] introspection: Split off private sources
Maybe you should define what you mean by public/private source then?! I understand that concept for header files. And indeed, public headers are separate already.
The headers weren't entirely separate actually. An example problematic header file is pango-script-private.h, which references ParenStackEntry, which is an internal non-namespaced structure. The new scanner will complain when seeing such structures, rather than simply assume it's public API. The patch arguably could have just removed the -private.h from the public sources, but it seems cleaner to also segregate off the private C files.
You still refer to "public sources" without defining that term. I don't know what that means. Headers included in the _SOURCES variables are not automatically public. Public headers are those and only those that are installed.
public source: Source files contain the gtk-doc for functions implementing public API.
So...what do you want to see here?
Created attachment 169198 [details] [review] introspection: Filter out private headers We shouldn't scan private headers. Also add --warn-all.
Alternative approach attached.
Comment on attachment 169198 [details] [review] introspection: Filter out private headers This was committed in 0aa7efebfbbe72336f5db23279ef1c93ab839b17