After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627972 - Add _EXPORT_PACKAGES for --pkg-export
Add _EXPORT_PACKAGES for --pkg-export
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 559704
 
 
Reported: 2010-08-25 18:13 UTC by Luca Bruno
Modified: 2015-02-07 17:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add _EXPORT_PACKAGES to Makefile.introspection (3.61 KB, patch)
2010-08-25 18:13 UTC, Luca Bruno 		accepted-commit_now Details | Review

Description Luca Bruno 2010-08-25 18:13:38 UTC 
Created attachment 168754 [details] [review]
Add _EXPORT_PACKAGES to Makefile.introspection

Hello,
I'd like to propose adding a new variable _EXPORT_PACKAGES that maps to --pkg-export, similar to _PACKAGES for --pkg.
The reason is that many .gir are generated with many --pkg thus creating many <package> tags.
The <package> tag is going to be used to specify the provided pkg-config package by the gir. Potentially, one .gir could provide more <package> (see for example Gio-2.0 with gio-2.0 and gio-unix-2.0).
Some gnome modules needing --pkg-export are: atk, gdk-pixbuf, gir-repository, gtksourceview, json, nautilus, pango, poppler, vte and more in the future.

Since almost all modules that depend on other packages need to specify the exported package, it's reasonable to add a new makefile variable.
Comment 1 Johan (not receiving bugmail) Dahlin 2010-08-27 21:06:13 UTC 
Review of attachment 168754 [details] [review]:

Looks good to me, thanks for the patch.
Comment 2 Luca Bruno 2010-08-28 09:35:21 UTC 
commit e108d02cf2d177293085380900ce1607b0f601bf
Author: Luca Bruno <lethalman88@gmail.com>
Date:   Wed Aug 25 19:50:17 2010 +0200

    Makefile.introspection: Add _EXPORT_PACKAGES variable.
    
    This new variable maps to --pkg-export.
Comment 3 André Klapper 2015-02-07 17:02:44 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]