GNOME Bugzilla – Bug 627910
Warnings emitted when -Wcast-qual used
Last modified: 2010-09-01 23:11:02 UTC
Created attachment 168705 [details] [review]
Clean up warnings emitted when -Wcast-qual used
When another project includes certain gstreamer headers and is using the
-Wcast-qual compiler flag, several warnings show up. Most are easy to correct.
The only questionable fix is with gst_byte_writer_set_pos, where there is a small
change to the API, to what it probably should have been in the first place, i.e. the first parameter should not have been const in the case of a 'setter' function.
Committed with miniscule changes, thanks for the patch!
Author: Jeffrey S. Smith <firstname.lastname@example.org>
Date: Thu Sep 2 00:01:25 2010 +0100
Fix casts in a bunch of inline functions to maintain correct const-ness
Make code including GStreamer headers compile with -Wcast-qual by
maintaining const-ness when casting. Also fix function signature of
gst_byte_writer_set_pos(): the byte writer should not be marked as