GNOME Bugzilla – Bug 627835
Base Rating Widget on Hyena
Last modified: 2010-09-08 16:54:42 UTC
This commits base the F-Spot rating widget on Hyena's one.
Created attachment 168633 [details] [review] Use ComplexMenuItem from Hyena
Created attachment 168634 [details] [review] Base rating widget on Hyena RatingEntry
The dependent bug must be commited to Hyena first and the Hyena submodule in F-Spot must include those patches.
Created attachment 168638 [details] [review] Base rating widget on Hyena RatingEntry (This commit also adds the new files to Monodevelop)
Review of attachment 168633 [details] [review]: Looks good.
Review of attachment 168638 [details] [review]: Lovely refactoring. Like the reduction in code. Can we split this out of MainApp (see below). I gradually want that module to become tiny, and the other assemblies to be the base of more awesome. ::: src/Clients/MainApp/FSpot.Widgets/FSpotRatingRenderer.cs @@ +20,3 @@ +namespace FSpot.Widgets +{ + public class FSpotRatingRenderer : RatingRenderer Can this be moved from MainApp to FSpot.Gui? ::: src/Clients/MainApp/FSpot.Widgets/IconView.cs @@ +970,3 @@ if (DisplayRatings && photo.Rating > 0 && region.X == draw.X && region.X != 0) { + var rating = new FSpotRatingRenderer () { + Size = 16, Value = (int) photo.Rating Isn't 16 the default value? No need to set it then, right?
Created attachment 168706 [details] [review] Base rating widget on Hyena RatingEntry ... and also move some of the files to FSpot.Core
Created attachment 168707 [details] [review] Base rating widget on Hyena RatingEntry next try.... I saw you comment regarding to the size of the stars. default of Hyena is 14. But I think 14 is also ok, it looks better (imho).
Review of attachment 168707 [details] [review]: Needs work on making it more discoverable, as discussed on XMPP.
committed Attachment 168707 [details] pushed as b0824dd - Base rating widget on Hyena RatingEntry