After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627689 - [deinterlace] Broken timestamps
[deinterlace] Broken timestamps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.25
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-23 04:18 UTC by David Schleef
Modified: 2010-08-23 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.50 KB, patch)
2010-08-23 04:19 UTC, David Schleef 		accepted-commit_now Details | Review

Description David Schleef 2010-08-23 04:18:36 UTC 
Outgoing timestamps on buffers created by deinterlace are wrong.  Why?  Because deinterlace duplicates (by gst_buffer_ref()) the incoming buffer as field1 and field2, then proceeds to modify the timestamps on each.  Oops.
Comment 1 David Schleef 2010-08-23 04:19:11 UTC 
Created attachment 168539 [details] [review]
patch
Comment 2 Sebastian Dröge (slomo) 2010-08-23 06:49:29 UTC 
Comment on attachment 168539 [details] [review]
patch

Right, thanks for noticing this. Amazing that this wasn't noticed before. I guess it's safe to get this into the next release so please push it :)
Comment 3 David Schleef 2010-08-23 09:53:18 UTC 
Pushed.

commit 4eee45debb6b31d221e1bbf0fa56564e0b378835
Author: David Schleef <ds@schleef.org>
Date:   Sun Aug 22 21:15:07 2010 -0700

    deinterlace: use separate buffer metadata for fields
    
    Call gst_buffer_make_metadata_writable() on buffers that are
    duplicated into fields.  Fixes #627689.