After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627568 - Replace old GDK drawing API
Replace old GDK drawing API
Product: system-monitor
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks: 626688
Reported: 2010-08-21 11:11 UTC by Sergey Nizovtsev
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Remove gdk_draw_drawable in load-graph (1.65 KB, patch)
2010-08-21 11:12 UTC, Sergey Nizovtsev
none Details | Review
Use gdk_window_set_back_pixmap for background (1.53 KB, patch)
2010-08-22 18:45 UTC, Sergey Nizovtsev
committed Details | Review

Description Sergey Nizovtsev 2010-08-21 11:11:12 UTC
According to all GDK Drawing functions should be replaced by cairo.
Comment 1 Sergey Nizovtsev 2010-08-21 11:12:32 UTC
Created attachment 168451 [details] [review]
Remove gdk_draw_drawable in load-graph
Comment 2 Sergey Nizovtsev 2010-08-22 18:45:25 UTC
Created attachment 168510 [details] [review]
Use gdk_window_set_back_pixmap for background

Maybe it's better to use window manager to set background instead of drawing it?
Comment 3 Javier Jardón (IRC: jjardon) 2010-09-22 12:37:49 UTC
Could this get a review, please? Soon system-monitor won't compile against latest GTK+ without these patches ...
Comment 4 Chris Kühl 2011-01-26 11:24:36 UTC
I've applied the patch from comment 2 to the gtk3 branch.
Comment 5 Chris Kühl 2011-01-27 14:01:01 UTC
Review of attachment 168510 [details] [review]:

Thanks. Committed to the gtk3 branch.
Comment 6 Chris Kühl 2011-02-11 15:45:30 UTC
This is now in master.