GNOME Bugzilla – Bug 627498
Orca should explicitly present the insertion and deletion of the last row in an OOo Writer table
Last modified: 2010-09-20 10:57:44 UTC
Steps to reproduce: 1. Create a new table in OOo Writer 2. Press Tab to move from cell to cell 3. At the end of the table press Tab one more time 4. Press Ctrl+Z Just before Step 3, Orca says "end of table". After step 3, it announce the new cell coordinates. However, if a user is not paying attention or is Tabbing quickly, he/she might not realize that step 3 resulted in the insertion of a new row at the end of the current table. Similarly, after step 4 (in which the accidentally-created row was removed), Orca presents the coordinates of the last cell in the table. It is left up to the user to conclude, based on those coordinates, that pressing Ctrl+Z causes the last row to be deleted. We should instead explicitly present these events to the user.
Created attachment 168406 [details] [review] proposed fix, new regression test included This patch addresses the case described in the opening report. There are other times we might wish to announce inserted and removed rows (and for that matter tables), but that goes beyond the scope of this bug. We can address those issues in other bugs/RFEs. I still need to run the rest of the OOo regression tests as a sanity check, but I believe this patch to be sound. Ale mind doing a review? Thanks! (btw, due to String freeze, we need to deal with this sooner rather than later.)
(Passed the OOo regression tests.)
Review of attachment 168406 [details] [review]: After the great lesson about AtkObjects and events, it's good for me :)
Comment on attachment 168406 [details] [review] proposed fix, new regression test included Thanks Ale! String announcement will be made shortly. http://git.gnome.org/browse/orca/commit/?id=fb2cb2e9427fcc232c94de845f9dca879840b6b2