After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627315 - [gjs-dbus] Rename internal method and make it public
[gjs-dbus] Rename internal method and make it public
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-18 22:33 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2010-08-19 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[gjs-dbus] Rename internal method and make it public (3.33 KB, patch)
2010-08-18 22:33 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2010-08-18 22:33:36 UTC
gjs_dbus_proxy_call_json_async does not allow a{sv} arguments
which need access to the message, so make this public
Comment 1 Johan (not receiving bugmail) Dahlin 2010-08-18 22:33:40 UTC
Created attachment 168244 [details] [review]
[gjs-dbus] Rename internal method and make it public
Comment 2 James Willcox 2010-08-19 13:22:24 UTC
Looks good to me
Comment 3 James Willcox 2010-08-19 13:22:42 UTC
Review of attachment 168244 [details] [review]:

Oops, should have used this :)

Looks good
Comment 4 Johan (not receiving bugmail) Dahlin 2010-08-19 13:24:19 UTC
Attachment 168244 [details] pushed as 747918b - [gjs-dbus] Rename internal method and make it public