GNOME Bugzilla – Bug 627289
souphttpsrc: tweak error messages
Last modified: 2010-09-12 14:06:23 UTC
Created attachment 168216 [details] [review] Slightly modifies souphttpsrc error messages I display error messages coming from elements to the user and the souphttpsrc messages seem a bit odd to users b/c they place the URL before the message. With long URIs, the cause/reason can be obstructed due to the way our GUI is laid out. This small patch corrects the issue by placing the reason before the URI in the error message. I wouldn't be opposed to removing the URI from the error message entirely b/c presumably you already know the URI you set it to or can easily pull it from the location property. And if you need to, you can append the URI to the error message yourself in your application's code.
Thanks, I'll commit this after the release in a few days. Including the URL in the error messages makes still sense IMHO, there's not always a location bar or the location bar doesn't contain the URL to the media file.
commit d011e96028b1a8c61dc1080e7ec91471effee58a Author: David Hoyt <dhoyt@llnl.gov> Date: Thu Aug 19 17:59:09 2010 +0200 souphttpsrc: Improve error messages Before they contained the URL before the actual failure. The other way around makes more sense and we do the same in other elements like filesrc. Fixes bug #627289.
URIs and file names shouldn't really be in the error message at all, but in the debug details.
FYI: Commit: 9dfad52a79916ec5dab7c0c7ab2431986a64066e URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=9dfad52a79916ec5dab7c0c7ab2431986a64066e Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Sun Sep 12 00:04:42 2010 +0100 soup: fix error messages Error messages should be translated. URIs and filenames should not be part of the error message string that's shown to the user. soup_message->reason_phrase is not translated and not suitable as error message for users (see libsoup documentation). Also fix up error codes a bit, as far as possible with the existing codes.