GNOME Bugzilla – Bug 627260
removing the sidebar closing button
Last modified: 2010-12-04 12:14:41 UTC
this report has been filed here: https://bugs.edge.launchpad.net/ubuntu/+source/nautilus/+bug/619678 "There is a cross button displayed on the top right corner of the sidebar. I've seen many new users who have accidentally closed the sidebar by clicking on this button. To restore this sidebar you have to go in the "view" menu, find the option, and check it again. The Ubuntu beginners I know are not able to restore it. Couldn't it be replaced by a switch button in the tool bar (to activate/deactivate it)? I've quickly made a little mock-up." https://bugs.edge.launchpad.net/ubuntu/+source/nautilus/+bug/619678/+attachment/1497253/+files/Nautilus%20mockup.png
Wouldn't it be better to just remove the close sidebar button altogether? It's not like it's a common action; an entry in the view menu should be enough.
Created attachment 168942 [details] [review] Patch This patch fixes bug.
Review of attachment 168942 [details] [review]: This patch alone is not enough, as you also need to remove the close button altogether from the source (not just avoid showing it).
Created attachment 175304 [details] [review] Improved git patch Hi Cosimo, I 've made the changes you pointed out in this patch
Review of attachment 175304 [details] [review]: This still needs work, you need to also remove the |close_button| variable, and the lines that create and add the STOCK_CLOSE image to the button (and the |image| variable too).
Created attachment 175308 [details] [review] Improved patch 2 Hi cosimo, Thanks for the review on the previous patch, here is an improved one. I hope its good.
Review of attachment 175308 [details] [review]: Looks better, thanks. Still not good enough to go though. ::: src/nautilus-side-pane.c @@ -388,3 @@ - - image = gtk_image_new_from_stock (GTK_STOCK_CLOSE, - GTK_ICON_SIZE_MENU); You still don't seem to remove the declaration of this variable (image).
Created attachment 175342 [details] [review] Improved patch 3 Hi cosimo! I can't forgive myself for the silly mistakes I made in the above patches. I am sorry for wasting your time in looking at incomplete patches. It so happened that for some reason I was in a hurry to prepare the above ones, and I am sure this one is fit.
Review of attachment 175342 [details] [review]: Looks good to me. Do you have a GNOME git account? If so, feel free to push to master, otherwise I can push it for you.
No, I don't have a GNOME git account, but I shall soon get one for Empathy.
This has already been fixed in master, where I removed the combobox to choose sidebar completely, since we're only keeping 'Places' and 'Tree'. Closing as FIXED.