After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627253 - [mpegtsparse] Post tags of channel and currently running event
[mpegtsparse] Post tags of channel and currently running event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-18 11:31 UTC by Sebastian Pölsterl
Modified: 2010-10-28 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Initial version (4.79 KB, patch)
2010-08-18 11:31 UTC, Sebastian Pölsterl 		none Details | Review
Improved patch (5.14 KB, patch)
2010-08-30 10:39 UTC, Sebastian Pölsterl 		committed Details | Review

Description Sebastian Pölsterl 2010-08-18 11:31:57 UTC 
Created attachment 168190 [details] [review]
Initial version

This patch gets the channel's name from the SDT and puts it in the ARTIST tag, the title and the duration of the currently running show are retrieved from the EIT.

Not sure if I should lock access to program->tspad->tags. In addition the ARTIST tag might not be the best choice for the channel's name.
Comment 1 Sebastian Pölsterl 2010-08-30 10:39:55 UTC 
Created attachment 169044 [details] [review]
Improved patch

I did some minor changes to the patch:
- Check if event's name is not NULL
- Free GstTagList in mpegts_parse_destroy_tspad
Comment 2 Zaheer Abbas Merali 2010-10-28 10:29:06 UTC 
Review of attachment 169044 [details] [review]:

looks good
Comment 3 Zaheer Abbas Merali 2010-10-28 10:55:08 UTC 
Review of attachment 169044 [details] [review]:

committed