After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627216 - Orca not brailling messages received via notify-osd
Orca not brailling messages received via notify-osd
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
2.31.x
Other All
: Normal normal
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-17 23:11 UTC by Paul Hunt
Modified: 2010-09-20 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (1.80 KB, patch)
2010-08-19 06:10 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Paul Hunt 2010-08-17 23:11:12 UTC 
Hello,

I've noticed that Orca is not brailling notifications that you receive via the notify-osd daemon.

These messages should be flashed on the braille display.
Comment 1 Joanmarie Diggs (IRC: joanie) 2010-08-19 06:10:41 UTC 
Created attachment 168261 [details] [review]
proposed fix

This solves it for me. Please test.

Note that I did not include the word 'Notification' in the braille. Rationale: It seems like a lot of cells to state something which I would *think* is implied by the appearance of a flash message when (odds are) an Orca command which results in a flash message was not just given.

But if people want that word in there as well, it's easy enough to add it. Lemme know.
Comment 2 Paul Hunt 2010-08-19 12:25:19 UTC 
Looks good Joanie,

Been running with it for about an hour and all notifications are being brailled.  And no side effects.

And no I certainly don't want the word notification included.  I only have a 20 cell display and I don't need half of it taken up with the word.

Thanks.
Comment 3 Paul Hunt 2010-08-19 14:36:19 UTC 
Joanie,

I noticed that notifications that are messages from IM conversations aren't being flashed.  They appear in braille but stay on the display.

This is the same as when Orca reports something from a chat room - they stay on the display too.

Is this deliberate?

I like this behaviour - gives me time to read the messages properly.
Comment 5 Joanmarie Diggs (IRC: joanie) 2010-08-19 17:54:45 UTC 
Thanks for the testing and feedback Paul.

As for the chat messages, yes those intentionally remain on the display.
Comment 6 Jose Vilmar Estacio de Souza 2010-08-22 22:46:27 UTC 
There should also be applied to notification-daemon?