After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627209 - If "Choose difficult blocks" is switched on, the "next block" indicator is wrong
If "Choose difficult blocks" is switched on, the "next block" indicator is wrong
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: quadrapassel
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-17 20:23 UTC by Pedro Villavicencio
Modified: 2012-01-31 23:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
[quadrapassel] Don't show a preview when "Choose difficult blocks" is switched on (2.27 KB, patch)
2010-08-19 09:28 UTC, Craig Duncan
committed Details | Review

Description Pedro Villavicencio 2010-08-17 20:23:16 UTC
this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/gnome-games/+bug/613295

"If "Choose difficult blocks" is switched on, the "next block" indicator is wrong
Tested using quadrapassel version 1:2.31.6-0ubuntu1."
Comment 1 Thomas Andersen 2010-08-17 20:39:09 UTC
This is kinda intentional as the most difficult block is only known when the current one is dropped. Maybe we should just disable the block preview in this mode? Jason?
Comment 2 Thomas Andersen 2010-08-19 05:36:03 UTC
Ideas for fixing it:
1) Just disable the block preview in "difficult blocks" mode
2) Display a question mark
3) Loop over all the blocks changing the preview every 500 ms or so
Comment 3 Craig Duncan 2010-08-19 09:28:21 UTC
Created attachment 168273 [details] [review]
[quadrapassel] Don't show a preview when "Choose difficult blocks" is switched on
Comment 4 Craig Duncan 2010-08-19 14:39:37 UTC
The patch has a bit of a problem, if "Choose difficult blocks" is switched on, then it won't display a preview in the theme selection dialog.

However a patch for another bug deals with this issue. The following patch should be applied after the one in this bug.

http://bugzilla-attachments.gnome.org/attachment.cgi?id=168292
Comment 5 Jason Clinton 2011-03-16 21:47:00 UTC
Comment on attachment 168273 [details] [review]
[quadrapassel] Don't show a preview when "Choose difficult blocks" is switched on

commit 7868fe1b2f4580877e0a746ac84adca82f1cdc4f
Author: Craig Duncan <bugzilla@duncanc.co.uk>
Date:   Thu Aug 19 10:25:56 2010 +0100

    Don't show a preview when "Choose difficult blocks" is switched on
    
    I've added a check during the preview generation,
    and if the bastard_mode flag is on then it sets the entire preview area as empty.
    
    I've also indicated on the preferences dialog that previews are unavailable.
    
    (Minor modifications for D_SEAL by jclinton)
Comment 6 Robert Ancell 2012-01-31 23:25:00 UTC
This bug is being reassigned to the "quadrapassel" component so we can close the gnometris bugzilla component.  Apologies for the mass email!