After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627172 - [gnome-shell-build-setup.sh] Fix for lsb_release system value containing space
[gnome-shell-build-setup.sh] Fix for lsb_release system value containing space
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-17 15:54 UTC by Frederic Crozat
Modified: 2010-08-17 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[gnome-shell-build-setup.sh] Fix for lsb_release system value containing space (1.75 KB, patch)
2010-08-17 15:54 UTC, Frederic Crozat 		committed Details | Review

Description Frederic Crozat 2010-08-17 15:54:06 UTC 
On SLED11, lsb_release system is "SUSE LINUX", breaking the script.
Adding quotes fixes this issue.
Comment 1 Frederic Crozat 2010-08-17 15:54:09 UTC 
Created attachment 168104 [details] [review]
[gnome-shell-build-setup.sh] Fix for lsb_release system value containing space

On SLED11, lsb_release system is "SUSE LINUX", breaking the script.
Adding quotes fixes this issue.
Comment 2 Colin Walters 2010-08-17 16:05:09 UTC 
Review of attachment 168104 [details] [review]:

It looks like this patch is stripping trailing whitespace from unmodified areas?  Please don't do that as a general rule.  But in this case we're unlikely to be annotating the build script, so just go ahead and commit.
Comment 3 Frederic Crozat 2010-08-17 16:28:10 UTC 
Attachment 168104 [details] pushed as 6c6527b - [gnome-shell-build-setup.sh] Fix for lsb_release system value containing space